-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add page for individual nft serials #692
Conversation
246a361
to
dac8974
Compare
a28b7f5
to
2bf2e55
Compare
d9ebede
to
dd3e712
Compare
b339408
to
3b485a1
Compare
3b485a1
to
46b60d6
Compare
Signed-off-by: Tim Schmidt <[email protected]>
Signed-off-by: Tim Schmidt <[email protected]>
Signed-off-by: Tim Schmidt <[email protected]>
Signed-off-by: Tim Schmidt <[email protected]>
9ad2bd8
to
2fdf2d6
Compare
Signed-off-by: Tim Schmidt <[email protected]>
2fdf2d6
to
787b5bf
Compare
I played with the current stage of the implementation. Nice work.
|
…ta a link Signed-off-by: Tim Schmidt <[email protected]>
I suggest you adjust the failing TokenNavigation e2e test by replacing the sequence which looks for the now disappeared anchor inside the NFT Holder Table by something like this:
and perhaps add a few assertions on the content of the page, such that we have at least a bit of e2e coverage for this brand new Serial Details page. |
Signed-off-by: Tim Schmidt <[email protected]>
SonarCloud Quality Gate failed. 1 Bug 0.0% Coverage The version of Java (11.0.17) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17. Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
Description:
Add page for individual nft serial details (including recent transactions)
Related issue(s):
Fixes #
Notes for reviewer:
Not sure how much token information should be retained/added for this
Checklist