Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support ERC tokens #1587

Merged
merged 52 commits into from
Jan 8, 2025
Merged

feat: Support ERC tokens #1587

merged 52 commits into from
Jan 8, 2025

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Jan 7, 2025

Description:

Provides the following 2 aspects of ERC token support

  • decorate contract details page for contracts which happen to be either ERC20 or ERC721, based on static lists of known ERCs currently stored in the repository and updated regularly.
  • search token names among the lists of ERC in addition to the search among HTS tokens.

Related issue(s):

Relates to #1500

ericleponner and others added 30 commits January 7, 2025 19:33
@ericleponner @svienot
Added ERC20Cache and AccountERC20Cache (experimental).
98e1f9b 
Signed-off-by: Eric Le Ponner <[email protected]>
@svienot
Initial support for ERC Tokens section in AccountDetails.
abb587d 
Signed-off-by: Simon Viénot <[email protected]>
@ericleponner @svienot
Added AccountERC20Cache.forgetContract() (to be used later).
a806afc 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Protopye of ERC20Table.refreshBalance().
9c50f98 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Fixed AccountERC20Cache.forgetContract().
f846409 
Signed-off-by: Eric Le Ponner <[email protected]>
@svienot
Change title of "Tokens" section to "HTS Tokens".
9d01381 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Put "HTS Tokens" section above "ERC Tokens".
c2c3e25 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add ERC20Cache.lookupContract() (for further use).
bf6dba3 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Better balance contract properties between left and right when enable…
e012082 
…Expiry is false.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add a 'VERIFIED' label at the top of the ContractDetails when relevant.
d9b4152 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add 'ERC Token' section and 'ERC20' label to the ContractDetails when…
8070cfa 
… relevant.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
HederaSchemas.ts -> MirrorNodeSchemas.ts
b80e824 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
ERC20Cache.load() catches 404.
3e87c24 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Adjust ContractDetails unit tests.
927bd4a 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
TokensSection is shown only if there is any token/nft/airdrop to disp…
56f4dce 
…lay.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
ERCTokensSection is shown only if there is any ERC to display.
d58b155 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Adjust maxSupply and totalSupply of the ERC20 according to decimals.
dd84f02 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Display only standard ERC20 parameters in ContractDetails.
7df9449 
Signed-off-by: Simon Viénot <[email protected]>
@ericleponner @svienot
Added erc20IndexURL and erc721IndexURL to NetworkConfig (to be used l…
486df74 
…ater).

Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
ContractDetails vue now uses ERC20InfoCache.
e0eddb3 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Fixed ERC20InfoCache.call()
d4cf34f 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Renamed ERC20Token as ERC20Contract.
6341a2e 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Moved ERC20InfoCache.loadXXX() to ERCUtils.
bc0fdc9 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Fixed regression in ERC20Table caused by renaming.
bad9372 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Moved AccountERC20Cache.getBalance() to ERCUtils.loadBalance().
f61b8ba 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Added ERC721 caches (to be used later).
9c3c9ee 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Added ERCTokensSection now displays ERC721Table view.
6ab4543 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Removed prototypal code from ERC721InfoCache.
7c8a109 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Applied lint recommendations.
281f8ec 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
ERCTokensSection.showSection now takes ERC721 tokens into account.
f5dab4e 
Signed-off-by: Eric Le Ponner <[email protected]>
ericleponner and others added 17 commits January 7, 2025 19:33
@ericleponner @svienot
ContractDetails vue now displays ERC721 token.
fd38ad9 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
Added debug trace in ERCUtils.call().
9afc41c 
Signed-off-by: Eric Le Ponner <[email protected]>
@ericleponner @svienot
ERC721InfoCache now auto-discovers ERC721 contract.
043205f 
Signed-off-by: Eric Le Ponner <[email protected]>
@svienot
Add (null) erc20IndexURL and erc721IndexURL parameters in networks-co…
6a86963 
…nfig.json.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add ContractAnalyzer.isVerified and remove unneeded computed in Contr…
8015787 
…actByteCodeSection and ContractDetails.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Display contract name (from verification or ERC token interface) and …
50f490a 
…tune display of contract 'pills'.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Fix typo in ContractResultsSection.
c082b28 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Introduce ContractERCSection component.
eb814af 
Slight refactoring of ContractDetails.
Add ERC type property.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Disable ERCTokensSection in AccountDetails for now.
9f4c9c3 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Remove debug trace
0d0cdff 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
First step of Searching for ERCs.
22cb4dd 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Fix typo in TokensByPopularity.
252df65 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
First complete prototype of ERC search.
e648961 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add configuration for ERC tokens index URLs.
1463979 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Get rid of ERCTokensSection.
8baa18f 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Fix lint errors and warnings.
93c5211 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add popular-tokens.json.
ffedc4a 
Signed-off-by: Simon Viénot <[email protected]>
@svienot svienot requested a review from ericleponner as a code owner January 7, 2025 19:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2025 •
edited
Loading

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.02% 25295 / 34172
🔵 Statements 74.02% 25295 / 34172
🔵 Functions 57.8% 970 / 1678
🔵 Branches 82.97% 4558 / 5493
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/account/FungibleTable.vue 90.54% 100% 0% 90.54% 89-91, 140-143
src/components/account/NftsTable.vue 91.66% 100% 0% 91.66% 102-104, 154-157
src/components/account/PendingFungibleAirdropTable.vue 91.13% 60% 0% 91.13% 97-99, 148-151
src/components/account/PendingNftAirdropTable.vue 91.56% 100% 0% 91.56% 103-105, 154-157
src/components/contract/ContractByteCodeSection.vue 77.97% 59.25% 7.69% 77.97% 1, 147-148, 171-172, 239-240, 252-254, 261-262, 265-266, 269-286, 288-295, 301, 310-317, 321-329, 340, 345, 349
src/components/contract/ContractERCSection.vue 96.25% 100% 100% 96.25% 113-115
src/components/contract/ContractResult.vue 100% 91.66% 100% 100%
src/components/contract/ContractResultsSection.vue 100% 80% 100% 100%
src/components/contract/ERC20ByNameTable.vue 100% 100% 100% 100%
src/components/contract/ERC20ByNameTableLoader.ts 7.14% 100% 0% 7.14% 27-28, 34-37, 43-51, 53-56, 58-64
src/components/contract/ERC721ByNameTable.vue 100% 100% 100% 100%
src/components/contract/ERC721ByNameTableLoader.ts 7.14% 100% 0% 7.14% 27-28, 34-37, 43-51, 53-56, 58-64
src/components/search/SearchAgent.ts 78.73% 80.91% 73.33% 78.73% 66, 79-80, 85-86, 93-94, 192-193, 195-204, 206-212, 391, 424-428, 464-467, 470-489, 533-534, 555-556, 593-598, 626-627, 632-633, 659-660, 679-683, 685-691, 694, 696, 729-733, 738-739, 742-743, 765-769, 774-775, 778-779
src/components/search/SearchController.ts 86.5% 88.88% 80% 86.5% 148-150, 169-170, 184-192, 239-241
src/components/token/TokensSection.vue 82.11% 84.09% 27.27% 82.11% 281-282, 285-291, 294-295, 299-308, 316-317, 321, 335-344, 347-348, 351-361, 369-370
src/config/NetworkConfig.ts 82.94% 60% 73.68% 82.94% 43-44, 46-47, 49-50, 52-53, 77-78, 92-93, 116-117, 119-120, 122-123, 127-128, 181-182, 253-261, 268-269, 304-305, 307-308
src/pages/ContractDetails.vue 98.71% 90.52% 33.33% 98.71% 36, 40, 43, 46
src/pages/ERC20ByName.vue 100% 100% 100% 100%
src/pages/ERC721ByName.vue 100% 100% 100% 100%
src/pages/TokensByPopularity.vue 100% 100% 100% 100%
src/utils/ERCUtils.ts 60.75% 40% 44.44% 60.75% 36-40, 45-49, 54-58, 80-81, 89, 103-107, 111-115, 134, 137-138
src/utils/RouteManager.ts 77.5% 77.77% 60.34% 77.5% 138, 174-182, 205-214, 217-226, 244-245, 263-272, 279-282, 285-286, 307-316, 319-323, 326-330, 333-342, 345-349, 352-356, 374-383, 386-390, 393-397, 408-417, 428-437, 448-457, 464-467, 478-479, 518-519, 536-537, 548, 564-565, 567-568, 570-571, 573-574, 576-577, 579-580, 582-583, 585-586, 588-589, 591-592, 594-595, 597, 608, 630-631, 634-635
src/utils/URLUtils.ts 86.15% 84% 100% 86.15% 41-42, 79-80, 84-86, 88-89
src/utils/analyzer/ContractAnalyzer.ts 81.81% 82.43% 87.5% 81.81% 74-84, 98-99, 130-131, 141, 159, 171-182, 226-230, 269-270, 283-284, 297-298
src/utils/cache/CacheUtils.ts 100% 100% 100% 100%
src/utils/cache/ERC20Cache.ts 71.42% 57.14% 100% 71.42% 33-37, 46-49, 61
src/utils/cache/ERC20InfoCache.ts 33.33% 66.66% 66.66% 33.33% 38, 50-76
src/utils/cache/ERC721Cache.ts 67.5% 57.14% 80% 67.5% 37-41, 50-53, 58-60, 70
src/utils/cache/ERC721InfoCache.ts 36% 50% 66.66% 36% 38, 42-43, 45-52, 66-68, 70-87
src/utils/parser/AccountLocParser.ts 86.84% 94.44% 83.33% 86.84% 71-72, 74-88, 94-95, 200
Generated in workflow #1546

svienot added 3 commits January 8, 2025 09:05
@svienot
Get rid of ERC20Table and ERC721Table.
f68a0bc 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Get rid of unused code.
8eae0fd 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Always show TokensSection when displaying My Account.
d20403b 
'Show all tokens' link present only when needed.

Signed-off-by: Simon Viénot <[email protected]>
svienot
svienot commented Jan 8, 2025
View reviewed changes
Copy link
Collaborator Author

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go.

ericleponner
ericleponner approved these changes Jan 8, 2025
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for me

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@svienot svienot merged commit 789d70e into main Jan 8, 2025
12 of 13 checks passed
@svienot svienot deleted the ERC-tokens branch January 8, 2025 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@svienot @ericleponner