Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add HCS-1 support for NFT metadata #1557

Merged
merged 7 commits into from
Dec 11, 2024
Merged

feat: add HCS-1 support for NFT metadata #1557

merged 7 commits into from
Dec 11, 2024

Conversation

svienot
Copy link
Collaborator

@svienot svienot commented Dec 11, 2024

Description:

These changes

  • build upon the recently added support for HCS-1 content in topics, to enhance TokenMetadataAnalyzer and hence allow interpretation of NFT metadata (and related assets) stored as HCS-1 topics.
  • display HCS-1 URIs (e.g. hcs://1/0.0.5016824 ) as hyperlinks to the corresponding TopicDetails view.

Related issue(s):

Relates to #1523

Notes for reviewer:

Screenshot 2024-12-11 at 16 07 44

@svienot
Leverage HCSAssetCache to display metadata and media stored in HCS-1 …
af4ffe8 
…topics.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Update TokenMetadataAnalyzer unit tests.
ab0e09c 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Disable TokenMetadataAnalyzer unit tests based on HCS-1 topic content…
09362b9 
… (zstd decompress library init() fails).

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Add HCSURI component (for further use).
b76e97a 
Signed-off-by: Simon Viénot <[email protected]>
@svienot
Enhance BlobValue to interpret HCS-1 topic URIs as links to TopicDeta…
afc1ce5 
…ils.

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Make use of HCSURI in TokenMetadataAnalyzer (remove support for metad…
7699870 
…ata value consisting of plain topic).

Signed-off-by: Simon Viénot <[email protected]>
@svienot
Remove (now unused) blob2topic() utility.
3975041 
Signed-off-by: Simon Viénot <[email protected]>
@github-actions GitHub Actions
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.07% 24835 / 33528
🔵 Statements 74.07% 24835 / 33528
🔵 Functions 57.88% 954 / 1648
🔵 Branches 83.01% 4542 / 5471
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/token/TokenMetadataAnalyzer.ts 71.79% 81.25% 90.9% 71.79% 103-105, 107, 145-149, 157-171, 231-232, 241, 249-250, 259-266, 280-286, 293-306, 308-309, 320-321, 323-326
src/components/values/BlobValue.vue 94.44% 84.84% 100% 94.44% 51-53, 137-138, 149, 165-166
src/utils/HCSURI.ts 58.33% 50% 50% 58.33% 25-28, 35-40
src/utils/URLUtils.ts 86.15% 84% 100% 86.15% 41-42, 79-80, 84-86, 88-89
Generated in workflow #1522

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

ericleponner
ericleponner approved these changes Dec 11, 2024
View reviewed changes
Copy link
Collaborator

@ericleponner ericleponner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit 5950d0b into main Dec 11, 2024
8 of 9 checks passed
@svienot svienot deleted the metadata-in-topic branch December 11, 2024 19:03
@svienot svienot linked an issue Dec 11, 2024 that may be closed by this pull request
Add HCS-1 support inside of Hashscan #1523
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericleponner ericleponner ericleponner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add HCS-1 support inside of Hashscan
2 participants
@svienot @ericleponner