Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: move top <section> declarations of page views to PageFrame #1554

Merged
merged 3 commits into from
Dec 11, 2024

Conversation

ericleponner
Copy link
Collaborator

Description:

Changes below move the top <section> declaration of page views to PageFrame.
They also move TopNavBar and Footer to ./src/components/page folder.

Related issue(s):

Fixes #1551

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Copy link

github-actions bot commented Dec 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 74.17% 24841 / 33491
🔵 Statements 74.17% 24841 / 33491
🔵 Functions 58.04% 956 / 1647
🔵 Branches 83.06% 4546 / 5473
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/components/page/PageFrame.vue 100% 100% 100% 100%
src/pages/AccountDetails.vue 38.79% 79.27% 0% 38.79% 1, 27-31, 33-38, 40-49, 51-52, 55-60, 62-85, 87-92, 94-106, 108-112, 115-118, 120-125, 128-129, 131-134, 136-137, 139-140, 143-148, 150, 152-154, 156-168, 170, 172-178, 180-184, 186-190, 192-195, 197, 199-202, 204, 206-209, 211-212, 214-215, 217-223, 225-226, 228-229, 231-236, 238-240, 242-246, 248-250, 252, 255-259, 261-265, 267, 269-272, 274, 276, 278, 280-282, 284-304, 306-312, 314-316, 318-326, 328, 422-428, 431-432, 434, 477-478, 483-484, 501-503
src/pages/Accounts.vue 100% 83.33% 100% 100%
src/pages/AccountsWithKey.vue 79.06% 100% 0% 79.06% 76, 81-84, 86-89
src/pages/AdminKeyDetails.vue 100% 81.81% 100% 100%
src/pages/BlockDetails.vue 95.62% 92.5% 20% 95.62% 188-190, 192-194
src/pages/Blocks.vue 100% 83.33% 100% 100%
src/pages/ContractDetails.vue 100% 91.57% 100% 100%
src/pages/Contracts.vue 92.06% 50% 50% 92.06% 37, 46, 48-50
src/pages/MainDashboard.vue 94.17% 100% 100% 94.17% 155-160
src/pages/MobileMenu.vue 100% 100% 100% 100%
src/pages/MobileSearch.vue 32.89% 100% 0% 32.89% 64-67, 69-74, 76-93, 95-105, 107-118
src/pages/NftDetails.vue 92.7% 85.96% 33.33% 92.7% 252, 284, 287-288, 293, 332-338, 365-373
src/pages/NodeDetails.vue 97.52% 83.33% 100% 97.52% 1, 39-42, 289
src/pages/Nodes.vue 99.18% 82.35% 100% 99.18% 1
src/pages/PageNotFound.vue 100% 100% 100% 100%
src/pages/RoutingSpec.vue 20.19% 100% 0% 20.19% 84, 86, 88-246, 249-253
src/pages/SearchHelp.vue 100% 100% 100% 100%
src/pages/Staking.vue 51.04% 100% 0% 51.04% 273-276, 278, 280-290, 292, 297-299, 301-303, 305-315, 317-321, 323-326, 328, 330-339, 341-343, 349-351, 357, 359-365, 367-369, 371-377, 379-381, 383, 385, 387-398, 400-404, 406, 408-421, 423-426, 428, 430-431, 433-444, 446-447, 452-455, 460-464, 466-508
src/pages/TokenDetails.vue 97.7% 97.22% 66.66% 97.7% 441, 474-479, 512-513
src/pages/Tokens.vue 100% 87.5% 100% 100%
src/pages/TokensByAccount.vue 100% 100% 100% 100%
src/pages/TokensByName.vue 100% 100% 100% 100%
src/pages/TokensByPopularity.vue 100% 100% 100% 100%
src/pages/TopicDetails.vue 97.14% 84.48% 100% 97.14% 40, 217-218, 222
src/pages/Topics.vue 97.95% 83.33% 100% 97.95% 87
src/pages/TransactionDetails.vue 98.99% 94.36% 50% 98.99% 1, 385, 455-456
src/pages/Transactions.vue 100% 100% 50% 100%
src/pages/TransactionsById.vue 66.66% 100% 0% 66.66% 72-74, 76-78, 80-82, 84, 86-90
Generated in workflow #1520

@ericleponner ericleponner marked this pull request as draft December 11, 2024 10:36
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@ericleponner ericleponner marked this pull request as ready for review December 11, 2024 11:00
Copy link
Collaborator

@svienot svienot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@svienot svienot merged commit d57758e into main Dec 11, 2024
7 of 9 checks passed
@svienot svienot deleted the page_frame_step2bis branch December 11, 2024 14:20
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 24.12.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor page views using a common component PageFrame
3 participants