Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up configurations #3331

Draft
wants to merge 3 commits into
base: 3099-Add-operator-tier
Choose a base branch
from

Conversation

victor-yanev
Copy link
Contributor

Description:

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@victor-yanev victor-yanev self-assigned this Dec 12, 2024
@victor-yanev victor-yanev added this to the 0.63.0 milestone Dec 12, 2024
@victor-yanev victor-yanev added the Technical Debt Issue which resolves technical debt label Dec 12, 2024
@victor-yanev victor-yanev changed the base branch from 3099-Add-operator-tier to main December 12, 2024 10:42
@victor-yanev victor-yanev changed the base branch from main to 3099-Add-operator-tier December 12, 2024 10:43
@victor-yanev victor-yanev mentioned this pull request Dec 12, 2024
2 tasks
@victor-yanev victor-yanev changed the base branch from 3099-Add-operator-tier to main December 12, 2024 10:56
@victor-yanev victor-yanev changed the base branch from main to 3099-Add-operator-tier December 12, 2024 10:57
Copy link

Test Results

0 files   -  20  0 suites   - 260   0s ⏱️ - 41m 37s
0 tests  - 612  0 ✅  - 606  0 💤  - 4  0 ❌  - 2 
0 runs   - 757  0 ✅  - 749  0 💤  - 6  0 ❌  - 2 

Results for commit 8fafaa6. ± Comparison against base commit b5e747f.

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 69.55%. Comparing base (f71eaf6) to head (8fafaa6).

Files with missing lines Patch % Lines
.../relay/src/lib/services/hapiService/hapiService.ts 71.42% 1 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (f71eaf6) and HEAD (8fafaa6). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f71eaf6) HEAD (8fafaa6)
server 1 0
ws-server 1 0
Additional details and impacted files
@@                     Coverage Diff                     @@
##           3099-Add-operator-tier    #3331       +/-   ##
===========================================================
- Coverage                   85.00%   69.55%   -15.46%     
===========================================================
  Files                          69       65        -4     
  Lines                        4682     4473      -209     
  Branches                     1048     1004       -44     
===========================================================
- Hits                         3980     3111      -869     
- Misses                        392     1046      +654     
- Partials                      310      316        +6     
Flag Coverage Δ
config-service 98.14% <ø> (ø)
relay 80.14% <77.77%> (+0.42%) ⬆️
server ?
ws-server ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ckages/config-service/src/services/globalConfig.ts 100.00% <ø> (ø)
...kages/config-service/src/services/loggerService.ts 90.00% <ø> (ø)
packages/relay/src/lib/constants.ts 94.82% <ø> (+7.52%) ⬆️
packages/relay/src/lib/relay.ts 88.40% <ø> (-3.15%) ⬇️
...s/relay/src/lib/services/hbarLimitService/index.ts 92.85% <100.00%> (-0.27%) ⬇️
.../relay/src/lib/services/hapiService/hapiService.ts 88.46% <71.42%> (+8.67%) ⬆️

... and 32 files with indirect coverage changes

Copy link

sonarcloud bot commented Dec 12, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Technical Debt Issue which resolves technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant