feat: change units of the value in eth gettransactionbyhash result (#…

[ebadiere]

Related issue(s):

Fixes #3053

Notes for reviewer:

Checklist

• Documented (Code comments, README, etc.)
• Tested (unit, integration, etc.)

[github-actions]

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 33,523.5 ms

Heap Statistics (before vs after executing the test):

• Total Heap Size: increased with 1.72 MB
• Total Heap Size Executable: no changes
• Total Physical Size: decreased with 344.06 KB
• Total Available Size: increased with 2.37 MB
• Total Global Handles Size: no changes
• Used Global Handles Size: decreased with 64.00 bytes
• Used Heap Size: decreased with 3.31 MB
• Heap Size Limit: no changes
• Malloced Memory: no changes
• External Memory: no changes
• Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

• Old Space:

  • Space Size: increased with 2.10 MB
  • Space Used Size: increased with 2.01 MB
  • Space Available Size: decreased with 393.16 KB
  • Physical Space Size: increased with 2.10 MB

• Large Object Space:

  • Space Size: increased with 835.58 KB
  • Space Used Size: increased with 813.50 KB
  • Space Available Size: no changes
  • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

[github-actions]

Tests

       3 files     298 suites   19s ⏱️
1 359 tests 1 358 ✔️ 1 💤 0 ❌
1 368 runs  1 367 ✔️ 1 💤 0 ❌

Results for commit 7a802c6.

♻️ This comment has been updated with latest results.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[github-actions]

Acceptance Tests

  19 files  244 suites   33m 0s ⏱️
605 tests 597 ✔️ 4 💤 4 ❌
733 runs  725 ✔️ 4 💤 4 ❌

Results for commit 7a802c6.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.92%. Comparing base (78cd1dd) to head (7a802c6).
Report is 1 commits behind head on release/0.57.

Additional details and impacted files

@@              Coverage Diff              @@
##           release/0.57    #3081   +/-   ##
=============================================
  Coverage         84.92%   84.92%           
=============================================
  Files                58       58           
  Lines              3906     3906           
  Branches            785      785           
=============================================
  Hits               3317     3317           
  Misses              348      348           
  Partials            241      241           

Flag	Coverage Δ
relay	85.11% <ø> (ø)
server	83.05% <ø> (ø)
ws-server	97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
packages/relay/src/lib/constants.ts	91.30% <ø> (ø)