feat: change units of the value in eth gettransactionbyhash result #3080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nadezhdapopovaa
requested review from
AlfredoG87,
ebadiere,
Nana-EC,
a team and
lukelee-sl
as code owners
natanasow
changed the title
🚨 Memory Leak Detected 🚨A potential memory leak has been detected in the test titled Details📊 Memory Leak Detection Report 📊 GC Type: MarkSweepCompact Heap Statistics (before vs after executing the test):
Heap Space Statistics (before vs after executing the test):
RecommendationsPlease investigate the memory allocations in this test, focusing on objects that are not being properly deallocated. |
2 tasks
ebadiere
approved these changes
Oct 9, 2024
Nana-EC
approved these changes
Oct 9, 2024
nadezhdapopovaa
force-pushed
the
3053-change-units-of-the-value-in-eth_gettransactionbyhash-result
branch
from
dda4ead
to
9898aeb
Compare
added 2 commits
October 9, 2024 18:30
Signed-off-by: Nadezhda Popova <[email protected]>
Signed-off-by: Nadezhda Popova <[email protected]>
nadezhdapopovaa
force-pushed
the
3053-change-units-of-the-value-in-eth_gettransactionbyhash-result
branch
from
9898aeb
to
84c4102
Compare
|
ebadiere
deleted the
3053-change-units-of-the-value-in-eth_gettransactionbyhash-result
branch
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3080 +/- ##
=======================================
Coverage 84.84% 84.84%
=======================================
Files 59 59
Lines 3939 3939
Branches 788 788
=======================================
Hits 3342 3342
Misses 359 359
Partials 238 238
Flags with carried forward coverage won't be shown. Click here to find out more.
|
ebadiere
pushed a commit
that referenced
this pull request
Oct 9, 2024
…3080) * fix: change unit of transaction value result Signed-off-by: Nadezhda Popova <[email protected]> * chore: reusable tinybarsToWeibars method and tests Signed-off-by: Nadezhda Popova <[email protected]> --------- Signed-off-by: Nadezhda Popova <[email protected]> Co-authored-by: Nadezhda Popova <[email protected]>
ebadiere
pushed a commit
that referenced
this pull request
Oct 9, 2024
…3080) * fix: change unit of transaction value result Signed-off-by: Nadezhda Popova <[email protected]> * chore: reusable tinybarsToWeibars method and tests Signed-off-by: Nadezhda Popova <[email protected]> --------- Signed-off-by: Nadezhda Popova <[email protected]> Co-authored-by: Nadezhda Popova <[email protected]> Signed-off-by: ebadiere <[email protected]>
ebadiere
added a commit
that referenced
this pull request
Oct 9, 2024
#3081) feat: change units of the value in eth gettransactionbyhash result (#3080) * fix: change unit of transaction value result * chore: reusable tinybarsToWeibars method and tests --------- Signed-off-by: Nadezhda Popova <[email protected]> Signed-off-by: ebadiere <[email protected]> Co-authored-by: Nadezhda Popova <[email protected]> Co-authored-by: Nadezhda Popova <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Convert value of a transaction from tinybars to weibars for consistency.
Related issue(s):
Fixes #3053
Notes for reviewer:
Checklist