Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Brownie example and description #3070

Merged
merged 7 commits into from
Oct 9, 2024
Merged

Conversation

arianejasuwienas
Copy link
Contributor

@arianejasuwienas arianejasuwienas commented Oct 4, 2024

Description:
Brownie tool and analysis and usage example.

Related issue(s):

#3071

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Signed-off-by: Mariusz Jasuwienas <[email protected]>
@arianejasuwienas arianejasuwienas self-assigned this Oct 4, 2024
@arianejasuwienas arianejasuwienas added the ArianeLabs Items ArianeLabs is contributing to label Oct 4, 2024
@arianejasuwienas arianejasuwienas added this to the 0.58.0 milestone Oct 4, 2024
@arianejasuwienas arianejasuwienas linked an issue Oct 4, 2024 that may be closed by this pull request
Signed-off-by: Mariusz Jasuwienas <[email protected]>
Copy link

github-actions bot commented Oct 4, 2024

Tests

       3 files     299 suites   19s ⏱️
1 354 tests 1 353 ✔️ 1 💤 0
1 363 runs  1 362 ✔️ 1 💤 0

Results for commit a167f30.

♻️ This comment has been updated with latest results.

Signed-off-by: Mariusz Jasuwienas <[email protected]>
Copy link

github-actions bot commented Oct 4, 2024

Acceptance Tests

  18 files  271 suites   30m 10s ⏱️
605 tests 597 ✔️ 4 💤 4
729 runs  719 ✔️ 6 💤 4

Results for commit a167f30.

♻️ This comment has been updated with latest results.

jeromy-cannon
jeromy-cannon previously approved these changes Oct 4, 2024
@ebadiere ebadiere changed the title Brownie example and description feat: Brownie example and description Oct 4, 2024
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling correction

ebadiere
ebadiere previously approved these changes Oct 7, 2024
Copy link
Collaborator

@ebadiere ebadiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG.

acuarica
acuarica previously approved these changes Oct 8, 2024
Copy link
Contributor

@acuarica acuarica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

nathanklick
nathanklick previously approved these changes Oct 8, 2024
Copy link

github-actions bot commented Oct 8, 2024

🚨 Memory Leak Detected 🚨

A potential memory leak has been detected in the test titled validates enforcement of request id. This may impact the application's performance and stability.

Details

📊 Memory Leak Detection Report 📊

GC Type: MarkSweepCompact
Cost: 29,367.9 ms

Heap Statistics (before vs after executing the test):

  • Total Heap Size: increased with 1.72 MB
  • Total Heap Size Executable: no changes
  • Total Physical Size: decreased with 344.06 KB
  • Total Available Size: increased with 1.62 MB
  • Total Global Handles Size: no changes
  • Used Global Handles Size: decreased with 64.00 bytes
  • Used Heap Size: decreased with 3.28 MB
  • Heap Size Limit: no changes
  • Malloced Memory: no changes
  • External Memory: no changes
  • Peak Malloced Memory: no changes

Heap Space Statistics (before vs after executing the test):

  • Old Space:

    • Space Size: increased with 2.10 MB
    • Space Used Size: increased with 2.09 MB
    • Space Available Size: decreased with 648.53 KB
    • Physical Space Size: increased with 2.10 MB
  • Large Object Space:

    • Space Size: increased with 835.58 KB
    • Space Used Size: increased with 813.50 KB
    • Space Available Size: no changes
    • Physical Space Size: increased with 835.58 KB

Recommendations

Please investigate the memory allocations in this test, focusing on objects that are not being properly deallocated.

Signed-off-by: Mariusz Jasuwienas <[email protected]>
Copy link

sonarcloud bot commented Oct 8, 2024

@ebadiere ebadiere self-requested a review October 9, 2024 21:33
@ebadiere ebadiere merged commit ae4563d into main Oct 9, 2024
43 checks passed
@ebadiere ebadiere deleted the brownie-example-and-description branch October 9, 2024 21:33
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.43%. Comparing base (9f86d43) to head (a167f30).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3070      +/-   ##
==========================================
- Coverage   84.84%   84.43%   -0.41%     
==========================================
  Files          59       62       +3     
  Lines        3939     4093     +154     
  Branches      788      823      +35     
==========================================
+ Hits         3342     3456     +114     
- Misses        359      391      +32     
- Partials      238      246       +8     
Flag Coverage Δ
relay 84.95% <ø> (ø)
server 83.57% <ø> (+0.14%) ⬆️
ws-server 97.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 14 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ArianeLabs Items ArianeLabs is contributing to
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Brownie tool analysis and usage example
5 participants