fix: Adding port mapping for debug when available #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
changed the title
AlfredoG87
added
the
Bug
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #64 +/- ##
=========================================
Coverage 54.33% 54.33%
Complexity 25 25
=========================================
Files 7 7
Lines 173 173
Branches 6 6
=========================================
Hits 94 94
Misses 75 75
Partials 4 4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
On a previous PR #57 changes to enable debug container were merged, however, the port was not added on the docker-compose file. This PR fixes that by adding the port mapping on the docker-compose file to be able to reach the debug port of the java process.
Related issue(s):
Fixes #
Notes for reviewer:
Checklist