Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: assigne, label and milestone checks #62

Merged
merged 3 commits into from
Jul 30, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Jul 30, 2024

Description:
On a previous commit a Pr-formmating GHA WF was introduced to make sure that all PRs have at least one Assignee, Label and that Milestone is also set. As well as title check to follow conventional-pr-tittle

However, only the conventional-pr-tittle was working, with this fix, all the other checks are working aswell.

Related issue(s):

Fixes #53

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 requested review from a team as code owners July 30, 2024 03:12
@AlfredoG87 AlfredoG87 changed the title fix: assigne, label and milestone checks fix: assigne, label and milestone checks, codecov config Jul 30, 2024
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (691a4c1) to head (d208d7e).

Additional details and impacted files
@@            Coverage Diff            @@
##               main      #62   +/-   ##
=========================================
  Coverage     54.33%   54.33%           
  Complexity       25       25           
=========================================
  Files             7        7           
  Lines           173      173           
  Branches          6        6           
=========================================
  Hits             94       94           
  Misses           75       75           
  Partials          4        4           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlfredoG87 AlfredoG87 self-assigned this Jul 30, 2024
…also greatly simplify the steps

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 force-pushed the fix-pr-formatting-improve-code-cov-config branch from 62c6b64 to 00191e8 Compare July 30, 2024 03:57
@AlfredoG87 AlfredoG87 added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Jul 30, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Jul 30, 2024
@AlfredoG87 AlfredoG87 assigned AlfredoG87 and unassigned AlfredoG87 Jul 30, 2024
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 changed the title fix: assigne, label and milestone checks, codecov config fix: assigne, label and milestone checks Jul 30, 2024
@AlfredoG87 AlfredoG87 merged commit 726e798 into main Jul 30, 2024
7 checks passed
@AlfredoG87 AlfredoG87 deleted the fix-pr-formatting-improve-code-cov-config branch July 30, 2024 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gate for PRs to have Milestone, Labels and Assignee(s)
2 participants