Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add compression mode support for BlockAsFileReader #449

Merged

Conversation

ata-nas
Copy link
Contributor

@ata-nas ata-nas commented Jan 7, 2025

Description:

  • add compression support for the reader

Related issue(s):

Fixes #350

Notes for reviewer:

N/A

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ata-nas ata-nas added the Block Node Issues/PR related to the Block Node. label Jan 7, 2025
@ata-nas ata-nas added this to the 0.4.0 milestone Jan 7, 2025
@ata-nas ata-nas self-assigned this Jan 7, 2025
@ata-nas ata-nas linked an issue Jan 7, 2025 that may be closed by this pull request
@ata-nas ata-nas force-pushed the 350-feat-add-compression-mode-support-for-blockasfilereader branch from 4ba28d6 to 59d21cb Compare January 8, 2025 10:24
@ata-nas ata-nas force-pushed the 350-feat-add-compression-mode-support-for-blockasfilereader branch from 59d21cb to 1934860 Compare January 8, 2025 10:56
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas ata-nas marked this pull request as ready for review January 8, 2025 14:01
@ata-nas ata-nas requested a review from a team as a code owner January 8, 2025 14:01
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! One other thing to adjust would be this logger:

#com.hedera.block.server.persistence.storage.write.BlockAsLocalDirWriter.level=FINE
. Please confirm you're getting output from somewhere in the persistence layer so we can uncomment a line in the logging.properties to troubleshoot issues.

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just 2 nit questions.

@ata-nas ata-nas merged commit 7a0420a into main Jan 9, 2025
17 checks passed
@ata-nas ata-nas deleted the 350-feat-add-compression-mode-support-for-blockasfilereader branch January 9, 2025 08:19
Copy link

codecov bot commented Jan 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.83%. Comparing base (c303fa0) to head (579a73f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #449      +/-   ##
============================================
+ Coverage     96.78%   96.83%   +0.04%     
- Complexity      409      420      +11     
============================================
  Files            82       82              
  Lines          1460     1483      +23     
  Branches         90       93       +3     
============================================
+ Hits           1413     1436      +23     
  Misses           34       34              
  Partials         13       13              
Files with missing lines Coverage Δ
...server/persistence/PersistenceInjectionModule.java 100.00% <100.00%> (ø)
.../persistence/storage/PersistenceStorageConfig.java 100.00% <100.00%> (ø)
...rsistence/storage/compression/NoOpCompression.java 100.00% <100.00%> (ø)
...rsistence/storage/compression/ZstdCompression.java 100.00% <100.00%> (ø)
...ence/storage/path/BlockAsLocalDirPathResolver.java 100.00% <100.00%> (ø)
...nce/storage/path/BlockAsLocalFilePathResolver.java 100.00% <100.00%> (ø)
...ersistence/storage/path/NoOpBlockPathResolver.java 100.00% <100.00%> (ø)
...rsistence/storage/read/BlockAsLocalFileReader.java 100.00% <100.00%> (ø)
...istence/storage/remove/BlockAsLocalDirRemover.java 84.21% <100.00%> (ø)
...rsistence/storage/write/BlockAsLocalDirWriter.java 100.00% <100.00%> (ø)
... and 1 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add compression mode support for BlockAsFileReader
3 participants