-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add compression mode support for BlockAsFileReader #449
feat: add compression mode support for BlockAsFileReader #449
Conversation
4ba28d6
to
59d21cb
Compare
Signed-off-by: Atanas Atanasov <[email protected]>
59d21cb
to
1934860
Compare
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! One other thing to adjust would be this logger:
#com.hedera.block.server.persistence.storage.write.BlockAsLocalDirWriter.level=FINE |
server/src/main/java/com/hedera/block/server/persistence/storage/PersistenceStorageConfig.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just 2 nit questions.
...main/java/com/hedera/block/server/persistence/storage/path/BlockAsLocalFilePathResolver.java
Show resolved
Hide resolved
...r/src/main/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReader.java
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #449 +/- ##
============================================
+ Coverage 96.78% 96.83% +0.04%
- Complexity 409 420 +11
============================================
Files 82 82
Lines 1460 1483 +23
Branches 90 93 +3
============================================
+ Hits 1413 1436 +23
Misses 34 34
Partials 13 13
|
Description:
Related issue(s):
Fixes #350
Notes for reviewer:
N/A
Checklist