Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Restoring javadocs verification #426

Merged
merged 1 commit into from
Dec 18, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Dec 18, 2024

Description:
Due to some of the work related to build deterministic we lost the ability to check for missing javadocs when build or assemble

Related issue(s):

Fixes #

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 marked this pull request as ready for review December 18, 2024 22:17
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner December 18, 2024 22:17
@AlfredoG87 AlfredoG87 self-assigned this Dec 18, 2024
@AlfredoG87 AlfredoG87 added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Dec 18, 2024
@AlfredoG87 AlfredoG87 added this to the 0.3.0 milestone Dec 18, 2024
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlfredoG87 AlfredoG87 merged commit 9bae709 into main Dec 18, 2024
9 of 16 checks passed
@AlfredoG87 AlfredoG87 deleted the fix-missing-javadocs-verification branch December 18, 2024 22:26
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (7a6702a) to head (6ff721d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #426   +/-   ##
=========================================
  Coverage     97.02%   97.02%           
  Complexity      409      409           
=========================================
  Files            82       82           
  Lines          1446     1446           
  Branches         89       89           
=========================================
  Hits           1403     1403           
  Misses           32       32           
  Partials         11       11           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants