-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate preconditions to use non-null error messages #415
Merged
ata-nas
merged 6 commits into
main
from
381-chore-migrate-preconditions-to-use-non-null-error-messages
Dec 18, 2024
Merged
chore: migrate preconditions to use non-null error messages #415
ata-nas
merged 6 commits into
main
from
381-chore-migrate-preconditions-to-use-non-null-error-messages
Dec 18, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Atanas Atanasov <[email protected]>
ata-nas
added
Improvement
Code changes driven by non business requirements
P2
Required to be completed in the assigned milestone, but may or may not impact release schedule.
Phase 2
Issue/PR related to Phase 2
labels
Dec 17, 2024
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
georgi-l95
previously approved these changes
Dec 17, 2024
ata-nas
requested review from
mattp-swirldslabs,
jsync-swirlds and
AlfredoG87
December 17, 2024 23:20
jsync-swirlds
previously approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a few opportunities to make Javadoc a little cleaner, which could be done in a future PR.
common/src/main/java/com/hedera/block/common/utils/Preconditions.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/hedera/block/common/utils/Preconditions.java
Outdated
Show resolved
Hide resolved
common/src/main/java/com/hedera/block/common/utils/Preconditions.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
ata-nas
dismissed stale reviews from jsync-swirlds and georgi-l95
via
December 18, 2024 08:52
ee0e40f
georgi-l95
approved these changes
Dec 18, 2024
jsync-swirlds
approved these changes
Dec 18, 2024
ata-nas
deleted the
381-chore-migrate-preconditions-to-use-non-null-error-messages
branch
December 18, 2024 15:41
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #415 +/- ##
============================================
- Coverage 97.06% 97.02% -0.04%
+ Complexity 416 409 -7
============================================
Files 82 82
Lines 1465 1446 -19
Branches 96 89 -7
============================================
- Hits 1422 1403 -19
Misses 32 32
Partials 11 11
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Improvement
Code changes driven by non business requirements
P2
Required to be completed in the assigned milestone, but may or may not impact release schedule.
Phase 2
Issue/PR related to Phase 2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related issue(s):
Fixes #381
Notes for reviewer:
Checklist