Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate preconditions to use non-null error messages #415

Merged

Conversation

ata-nas
Copy link
Contributor

@ata-nas ata-nas commented Dec 17, 2024

Description

  • migrate the preconditions class to use non-null error messages as seen in this comment

Related issue(s):

Fixes #381

Notes for reviewer:

  • just some extra care in case I have missed something

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas ata-nas added Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Phase 2 Issue/PR related to Phase 2 labels Dec 17, 2024
@ata-nas ata-nas added this to the 0.4.0 milestone Dec 17, 2024
@ata-nas ata-nas self-assigned this Dec 17, 2024
@ata-nas ata-nas linked an issue Dec 17, 2024 that may be closed by this pull request
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas ata-nas marked this pull request as ready for review December 17, 2024 11:36
@ata-nas ata-nas requested a review from a team as a code owner December 17, 2024 11:36
georgi-l95
georgi-l95 previously approved these changes Dec 17, 2024
jsync-swirlds
jsync-swirlds previously approved these changes Dec 17, 2024
Copy link
Member

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a few opportunities to make Javadoc a little cleaner, which could be done in a future PR.

@ata-nas ata-nas merged commit 27d3197 into main Dec 18, 2024
11 checks passed
@ata-nas ata-nas deleted the 381-chore-migrate-preconditions-to-use-non-null-error-messages branch December 18, 2024 15:41
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.02%. Comparing base (72d8e84) to head (ee0e40f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #415      +/-   ##
============================================
- Coverage     97.06%   97.02%   -0.04%     
+ Complexity      416      409       -7     
============================================
  Files            82       82              
  Lines          1465     1446      -19     
  Branches         96       89       -7     
============================================
- Hits           1422     1403      -19     
  Misses           32       32              
  Partials         11       11              
Files with missing lines Coverage Δ
...a/com/hedera/block/common/utils/Preconditions.java 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. Phase 2 Issue/PR related to Phase 2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: migrate preconditions to use non-null error messages
3 participants