Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new BlockReader implementation for block-as-file #385

Merged

Conversation

ata-nas
Copy link
Contributor

@ata-nas ata-nas commented Dec 6, 2024

Description:

Related issue(s):

Fixes #349

Notes for reviewer:

  • what would be the best way to parse the block file, having a file input stream and calling readAllBytes does not seem like the best option, there are other (based on the api), but which one would be preferable?

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ata-nas ata-nas added this to the 0.3.0 milestone Dec 6, 2024
@ata-nas ata-nas self-assigned this Dec 6, 2024
@ata-nas ata-nas linked an issue Dec 6, 2024 that may be closed by this pull request
@ata-nas ata-nas marked this pull request as ready for review December 6, 2024 14:41
@ata-nas ata-nas requested a review from a team as a code owner December 6, 2024 14:41
@ata-nas ata-nas added the Block Node Issues/PR related to the Block Node. label Dec 6, 2024
Signed-off-by: Atanas Atanasov <[email protected]>
AlfredoG87
AlfredoG87 previously approved these changes Dec 6, 2024
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Atanas Atanasov <[email protected]>
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
AlfredoG87
AlfredoG87 previously approved these changes Dec 11, 2024
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few nits, looks good!

Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.98%. Comparing base (a278936) to head (aa76557).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #385      +/-   ##
============================================
- Coverage     97.23%   96.98%   -0.26%     
- Complexity      375      398      +23     
============================================
  Files            76       79       +3     
  Lines          1338     1425      +87     
  Branches         91       94       +3     
============================================
+ Hits           1301     1382      +81     
- Misses           28       32       +4     
- Partials          9       11       +2     
Files with missing lines Coverage Δ
...server/persistence/PersistenceInjectionModule.java 100.00% <100.00%> (ø)
...rsistence/storage/read/BlockAsLocalFileReader.java 100.00% <100.00%> (ø)

... and 16 files with indirect coverage changes

Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ata-nas ata-nas merged commit 4201258 into main Dec 16, 2024
9 checks passed
@ata-nas ata-nas deleted the 349-feat-new-blockreader-implementation-for-block-as-file branch December 16, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Block Node Issues/PR related to the Block Node.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: new BlockReader implementation for block-as-file
4 participants