-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: new BlockReader implementation for block-as-file #385
feat: new BlockReader implementation for block-as-file #385
Conversation
Signed-off-by: Atanas Atanasov <[email protected]>
...r/src/main/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReader.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
...r/src/main/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReader.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...r/src/main/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReader.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReader.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReaderTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
...c/test/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReaderTest.java
Show resolved
Hide resolved
...c/test/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReaderTest.java
Show resolved
Hide resolved
...r/src/main/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReader.java
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a few nits, looks good!
...r/src/main/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReader.java
Outdated
Show resolved
Hide resolved
...r/src/main/java/com/hedera/block/server/persistence/storage/read/BlockAsLocalFileReader.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #385 +/- ##
============================================
- Coverage 97.23% 96.98% -0.26%
- Complexity 375 398 +23
============================================
Files 76 79 +3
Lines 1338 1425 +87
Branches 91 94 +3
============================================
+ Hits 1301 1382 +81
- Misses 28 32 +4
- Partials 9 11 +2
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Related issue(s):
Fixes #349
Notes for reviewer:
Checklist