feat: add logging configurability to the simulator #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
georgi-l95
changed the title
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
ata-nas
previously approved these changes
Dec 5, 2024
Signed-off-by: georgi-l95 <[email protected]>
georgi-l95
dismissed stale reviews from ata-nas and mattp-swirldslabs
via
73af5b2
AlfredoG87
approved these changes
Dec 5, 2024
simulator/src/main/java/com/hedera/block/simulator/BlockStreamSimulatorApp.java
Show resolved
Hide resolved
ata-nas
approved these changes
Dec 5, 2024
georgi-l95
deleted the
377-feat-add-logging-configurability-to-the-simulator
branch
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #378 +/- ##
============================================
- Coverage 97.77% 97.08% -0.69%
- Complexity 343 344 +1
============================================
Files 70 70
Lines 1256 1271 +15
Branches 88 88
============================================
+ Hits 1228 1234 +6
- Misses 19 28 +9
Partials 9 9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR adds logging configuration in the simulator, this way using logging.properties one can set the verbose
Related issue(s):
Fixes #377
Notes for reviewer:
Checklist