feat: server properties configurable #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredoG87
changed the title
AlfredoG87
added
Block Node
…perties. Adding 2 new properties to the newly created ServerConfig, and mapping them for ENV override using the ServerMappedConfigSourceInitializer. maxMessageSizeBytes and port. Replacing the hardcoded values on the codebase with the new configurable properties from ServerConfig. Added the new configuration to the ConfigInjectionModule Created UT for testing the Config validations and restrictions. Added Test case for ConfigInjectionModule to retrieve the newly config object. Signed-off-by: Alfredo Gutierrez <[email protected]>
…g object. Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
force-pushed
the
344-max-message-size-configurable
branch
from
ca87106 to
01128d4
Compare
ata-nas
reviewed
Nov 27, 2024
server/src/main/java/com/hedera/block/server/config/ServerMappedConfigSourceInitializer.java
Show resolved
Hide resolved
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
ata-nas
approved these changes
Nov 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
============================================
+ Coverage 97.74% 97.77% +0.03%
- Complexity 334 343 +9
============================================
Files 69 70 +1
Lines 1239 1256 +17
Branches 86 88 +2
============================================
+ Hits 1211 1228 +17
Misses 19 19
Partials 9 9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #344
Fixes #345
Notes for reviewer:
Checklist