fix: integrated PBJ error propagation #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matt Peterson <[email protected]>
mattp-swirldslabs
added
the
Bug
Signed-off-by: Matt Peterson <[email protected]>
AlfredoG87
previously approved these changes
Nov 25, 2024
server/src/main/java/com/hedera/block/server/consumer/ConsumerStreamResponseObserver.java
Outdated
Show resolved
Hide resolved
ata-nas
previously approved these changes
Nov 26, 2024
server/src/main/java/com/hedera/block/server/consumer/ConsumerStreamResponseObserver.java
Outdated
Show resolved
Hide resolved
…er observers. Added comments Signed-off-by: Matt Peterson <[email protected]>
mattp-swirldslabs
dismissed stale reviews from ata-nas and AlfredoG87
via
e3fdae4
Signed-off-by: Matt Peterson <[email protected]>
ata-nas
approved these changes
Nov 26, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #362 +/- ##
============================================
+ Coverage 97.72% 97.74% +0.01%
- Complexity 332 334 +2
============================================
Files 69 69
Lines 1229 1239 +10
Branches 86 86
============================================
+ Hits 1201 1211 +10
Misses 19 19
Partials 9 9
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes PBJ ticket #304
Notes for reviewer:
Checklist