-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: adjust smoke tests to make them more robust in GHA #318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattp-swirldslabs
added
the
Bug
A error that causes the feature to behave differently than what was expected based on design docs
label
Oct 28, 2024
Signed-off-by: Matt Peterson <[email protected]>
…s first Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
mattp-swirldslabs
force-pushed
the
00317-smoke-test-bug
branch
from
November 6, 2024 15:27
ef648f4
to
227391c
Compare
rbarkerSL
approved these changes
Nov 6, 2024
mattp-swirldslabs
changed the title
fix: smoke tests failure
refactor: adjust smoke tests to make them more robust in GHA
Nov 6, 2024
georgi-l95
approved these changes
Nov 7, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #318 +/- ##
=========================================
Coverage 98.48% 98.48%
Complexity 294 294
=========================================
Files 63 63
Lines 1119 1119
Branches 79 79
=========================================
Hits 1102 1102
Misses 11 11
Partials 6 6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
A error that causes the feature to behave differently than what was expected based on design docs
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #324
Notes for reviewer:
Checklist