Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: adjust smoke tests to make them more robust in GHA #318

Merged
merged 8 commits into from
Nov 7, 2024

Conversation

mattp-swirldslabs
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs commented Oct 28, 2024

Description:

Related issue(s):

Fixes #324

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@mattp-swirldslabs mattp-swirldslabs added the Bug A error that causes the feature to behave differently than what was expected based on design docs label Oct 28, 2024
@mattp-swirldslabs mattp-swirldslabs added this to the 0.2.0 milestone Oct 28, 2024
@mattp-swirldslabs mattp-swirldslabs self-assigned this Oct 28, 2024
@mattp-swirldslabs mattp-swirldslabs changed the title wip: debugging fix: smoke tests failure Oct 28, 2024
@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review November 6, 2024 14:45
@mattp-swirldslabs mattp-swirldslabs requested review from a team as code owners November 6, 2024 14:45
@mattp-swirldslabs mattp-swirldslabs changed the title fix: smoke tests failure refactor: adjust smoke tests to make them more robust in GHA Nov 6, 2024
@mattp-swirldslabs mattp-swirldslabs merged commit a6ecd97 into main Nov 7, 2024
17 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00317-smoke-test-bug branch November 7, 2024 15:47
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.48%. Comparing base (b143a45) to head (227391c).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #318   +/-   ##
=========================================
  Coverage     98.48%   98.48%           
  Complexity      294      294           
=========================================
  Files            63       63           
  Lines          1119     1119           
  Branches         79       79           
=========================================
  Hits           1102     1102           
  Misses           11       11           
  Partials          6        6           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A error that causes the feature to behave differently than what was expected based on design docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor: Adjust the smoke tests so they are more robust in the GHA environment
4 participants