-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: introduce tests in common module #274
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ata-nas
added
Tests
issue related to enhancing the tests
Common
Issue/PR related to Common module
labels
Oct 17, 2024
ata-nas
force-pushed
the
273-test-introduce-tests-in-common-module
branch
from
October 21, 2024 14:20
e0aef30
to
6e89f5e
Compare
AlfredoG87
approved these changes
Oct 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ata-nas
force-pushed
the
273-test-introduce-tests-in-common-module
branch
from
October 22, 2024 07:06
6e89f5e
to
dc57832
Compare
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
ata-nas
force-pushed
the
273-test-introduce-tests-in-common-module
branch
from
October 22, 2024 07:32
dc57832
to
af0e133
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #274 +/- ##
============================================
- Coverage 99.78% 99.59% -0.20%
- Complexity 259 272 +13
============================================
Files 52 54 +2
Lines 938 981 +43
Branches 64 70 +6
============================================
+ Hits 936 977 +41
- Misses 2 3 +1
- Partials 0 1 +1 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
:common
moduleRelated issue(s):
Fixes #273
Notes for reviewer:
Checklist
com.hedera.block.common.utils.StringUtilities
com.hedera.block.common.utils.FileUtilities