Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: introduce tests in common module #274

Merged
merged 7 commits into from
Oct 22, 2024

Conversation

ata-nas
Copy link
Contributor

@ata-nas ata-nas commented Oct 17, 2024

Description:

  • add tests in the :common module

Related issue(s):
Fixes #273

Notes for reviewer:

  • am I missing some tests or edge cases?

Checklist

  • add unit tests for com.hedera.block.common.utils.StringUtilities
  • add unit tests for com.hedera.block.common.utils.FileUtilities

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@ata-nas ata-nas added Tests issue related to enhancing the tests Common Issue/PR related to Common module labels Oct 17, 2024
@ata-nas ata-nas added this to the 0.2.0 milestone Oct 17, 2024
@ata-nas ata-nas self-assigned this Oct 17, 2024
@ata-nas ata-nas linked an issue Oct 17, 2024 that may be closed by this pull request
@ata-nas ata-nas marked this pull request as ready for review October 17, 2024 14:25
@ata-nas ata-nas requested a review from a team as a code owner October 17, 2024 14:25
@ata-nas ata-nas marked this pull request as draft October 17, 2024 14:30
@ata-nas ata-nas marked this pull request as ready for review October 18, 2024 07:51
@ata-nas ata-nas force-pushed the 273-test-introduce-tests-in-common-module branch from e0aef30 to 6e89f5e Compare October 21, 2024 14:20
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ata-nas ata-nas force-pushed the 273-test-introduce-tests-in-common-module branch from 6e89f5e to dc57832 Compare October 22, 2024 07:06
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
Signed-off-by: Atanas Atanasov <[email protected]>
@ata-nas ata-nas force-pushed the 273-test-introduce-tests-in-common-module branch from dc57832 to af0e133 Compare October 22, 2024 07:32
@ata-nas ata-nas merged commit f5f1ed2 into main Oct 22, 2024
13 checks passed
@ata-nas ata-nas deleted the 273-test-introduce-tests-in-common-module branch October 22, 2024 16:56
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.59%. Comparing base (560404c) to head (af0e133).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #274      +/-   ##
============================================
- Coverage     99.78%   99.59%   -0.20%     
- Complexity      259      272      +13     
============================================
  Files            52       54       +2     
  Lines           938      981      +43     
  Branches         64       70       +6     
============================================
+ Hits            936      977      +41     
- Misses            2        3       +1     
- Partials          0        1       +1     

see 2 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Common Issue/PR related to Common module Tests issue related to enhancing the tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test: introduce tests in common module
2 participants