feat: cAdvisor Docker System Metrics and Dashboard for Dev Docker Stack #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…admin user - Added cAdvisor to Docker dev Stack to collect system metrics on host and containers - Added cAdvisor to list of targets to scrap from prometheus instance of the stack - Added a Dashboard for System Host and Container metrics visualization on grafana Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
added
Improvement
mattp-swirldslabs
approved these changes
Oct 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
=========================================
Coverage 99.66% 99.66%
Complexity 248 248
=========================================
Files 51 51
Lines 907 907
Branches 61 61
=========================================
Hits 904 904
Misses 3 3 |
No I was not, but maybe we can work it out on a follow up PR, since is not as straight forwards as I originally thought, I think there is something missing or wrong on the docker-compose.yaml for all containers in order to get them. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue(s):
Fixes #257
Notes for reviewer:
Checklist