Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update-env.sh now injects JAVA_OPTS params #245

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

mattp-swirldslabs
Copy link
Contributor

Description:

  • Added shell code to append the JVM memory requirements via JAVA_OPTS into the .env file

Related issue(s):

Fixes #244

@mattp-swirldslabs mattp-swirldslabs self-assigned this Oct 10, 2024
@mattp-swirldslabs mattp-swirldslabs added this to the 0.1.0 milestone Oct 10, 2024
@mattp-swirldslabs mattp-swirldslabs added the dependencies Pull requests that update a dependency file label Oct 10, 2024
@mattp-swirldslabs mattp-swirldslabs marked this pull request as ready for review October 10, 2024 15:02
@mattp-swirldslabs mattp-swirldslabs requested a review from a team as a code owner October 10, 2024 15:02
Copy link
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattp-swirldslabs mattp-swirldslabs merged commit dca9566 into main Oct 10, 2024
15 of 17 checks passed
@mattp-swirldslabs mattp-swirldslabs deleted the 00244-env-java-opts branch October 10, 2024 15:44
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.66%. Comparing base (d55321f) to head (ff1f35e).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #245   +/-   ##
=========================================
  Coverage     99.66%   99.66%           
  Complexity      247      247           
=========================================
  Files            50       50           
  Lines           903      903           
  Branches         61       61           
=========================================
  Hits            900      900           
  Misses            3        3           

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add docker jvm JAVA_OPTS params to .env
2 participants