-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Arch changes to address performance bottlenecks #171
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, some questions, other than that is fine IMO.
server/src/main/java/com/hedera/block/server/persistence/StreamPersistenceHandlerImpl.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good Job, leaved some comments, mostly nits some questions and probably future considerations that can be addressed in a future PR.
server/src/main/java/com/hedera/block/server/mediator/LiveStreamMediatorImpl.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/notifier/NotifierBuilder.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/notifier/NotifierInjectionModule.java
Outdated
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/notifier/NotifierConfig.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/config/ConfigInjectionModule.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/service/ServiceStatusImpl.java
Show resolved
Hide resolved
dd5fa4b
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
…led broken tests Signed-off-by: Matt Peterson <[email protected]>
…tor and the notifier Signed-off-by: Matt Peterson <[email protected]>
…terface Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
…e ringbuffer Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
…T tests Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
… fix initialization Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
… and the app.properties to work with containers Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
Signed-off-by: Matt Peterson <[email protected]>
…etons Signed-off-by: Matt Peterson <[email protected]>
… resources app.properties Signed-off-by: Matt Peterson <[email protected]>
33c95f2
to
33eb36b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 👍
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #171 +/- ##
=============================================
- Coverage 100.00% 99.73% -0.27%
- Complexity 160 208 +48
=============================================
Files 35 44 +9
Lines 616 763 +147
Branches 37 48 +11
=============================================
+ Hits 616 761 +145
- Misses 0 2 +2
|
Changes:
Closes #168