Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simulator blockstream manager #169

Merged
merged 5 commits into from
Sep 10, 2024
Merged

feat: Simulator blockstream manager #169

merged 5 commits into from
Sep 10, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Sep 9, 2024 •
edited
Loading

Description:

  • Adding BlockAsFileBlockStreamManager as a BlockStreamManager,
  • Improved BlockStreamManager interface
  • Unit Tests
  • Example BlockStream in Tar
  • Gradle Task to untar the example BlockStream
  • Other example files
  • Updated the version for the protobuf to be compatible with generated example blockstream

Related issue(s):

Fixes #108
Fixes #158

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87
BlockAsFileBlockStreamManager impl for BlockStreamManager, its unit t…
07af35f 
…ests, needed files for testing, and gradle task for untar the file with the 2445 blockstream

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87
improvements to make the build work to untar the test files
be78b8e 
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 self-assigned this Sep 9, 2024
@AlfredoG87 AlfredoG87 added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Sep 9, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Sep 9, 2024
@AlfredoG87 AlfredoG87 added the P2 Required to be completed in the assigned milestone, but may or may not impact release schedule. label Sep 9, 2024
@AlfredoG87 AlfredoG87 force-pushed the simulator-blockstream-manager branch from 77c292d to 727b1b4 Compare September 9, 2024 23:26
@AlfredoG87 AlfredoG87 marked this pull request as ready for review September 9, 2024 23:39
@AlfredoG87 AlfredoG87 requested review from a team as code owners September 9, 2024 23:39
mattp-swirldslabs
mattp-swirldslabs reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good. Let's sync up on a few of the comments.

simulator/src/main/java/com/hedera/block/simulator/generator/BlockAsFileBlockStreamManager.java Show resolved Hide resolved
simulator/src/main/java/com/hedera/block/simulator/generator/BlockStreamManager.java Show resolved Hide resolved
simulator/src/main/java/com/hedera/block/simulator/generator/Utils.java Outdated Show resolved Hide resolved
simulator/src/main/java/com/hedera/block/simulator/generator/BlockAsFileBlockStreamManager.java Outdated Show resolved Hide resolved
simulator/src/main/java/com/hedera/block/simulator/generator/BlockAsFileBlockStreamManager.java Outdated Show resolved Hide resolved
georgi-l95
georgi-l95 reviewed Sep 10, 2024
View reviewed changes
Copy link
Contributor

@georgi-l95 georgi-l95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall very good work 👍

simulator/src/main/resources/app.properties Show resolved Hide resolved
.gitignore Show resolved Hide resolved
@AlfredoG87
addressing feedback of PR Reviews
7b3dc4b 
Signed-off-by: Alfredo Gutierrez <[email protected]>
mattp-swirldslabs
mattp-swirldslabs approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks Fredy

@AlfredoG87 AlfredoG87 merged commit 9dae530 into main Sep 10, 2024
13 checks passed
@AlfredoG87 AlfredoG87 deleted the simulator-blockstream-manager branch September 10, 2024 18:02
@codecov Codecov
Copy link

codecov bot commented Sep 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e392f2b) to head (7b3dc4b).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff             @@
##                main      #169   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       147       160   +13     
===========================================
  Files             34        35    +1     
  Lines            561       616   +55     
  Branches          29        37    +8     
===========================================
+ Hits             561       616   +55
Files with missing lines Coverage Δ
...edera/block/simulator/BlockStreamSimulatorApp.java 100.00% <ø> (ø)
...block/simulator/config/data/BlockStreamConfig.java 100.00% <100.00%> (ø)
...lator/generator/BlockAsFileBlockStreamManager.java 100.00% <100.00%> (ø)
...va/com/hedera/block/simulator/generator/Utils.java 100.00% <100.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@georgi-l95 georgi-l95 georgi-l95 left review comments

@rbarkerSL rbarkerSL rbarkerSL approved these changes

@mattp-swirldslabs mattp-swirldslabs mattp-swirldslabs approved these changes

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon jeromy-cannon is a code owner automatically assigned from hashgraph/release-engineering-managers

Assignees

@AlfredoG87 AlfredoG87

Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. P2 Required to be completed in the assigned milestone, but may or may not impact release schedule.
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

Load the Block Simulator with recorded Block Stream data Integrate real protobuf types with the simulator
4 participants
@AlfredoG87 @georgi-l95 @mattp-swirldslabs @rbarkerSL