Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Simulator Base Project #162

Merged
merged 10 commits into from
Sep 5, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Aug 30, 2024

Description:

  • Adds a new subproject for simulator
  • Adds Configuration Framework.
  • Integrates with Hedera-Protobuf and PBJ Types
  • Implements DI Dagger across app
  • Runs Entry point.
  • JUnit
  • Unit Tests for all above

Related issue(s):

Fixes #106

Notes for reviewer:

The Generator section is there as a placeholder intended to change on next PR, don't pay attention to either interface, impl or test related to Generator.

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

@AlfredoG87 AlfredoG87 linked an issue Aug 30, 2024 that may be closed by this pull request
4 tasks
@AlfredoG87 AlfredoG87 force-pushed the 106-create-infrastructure-for-the-simulator branch from e911f55 to 37a95e8 Compare August 30, 2024 21:53
@AlfredoG87 AlfredoG87 self-assigned this Aug 30, 2024
@AlfredoG87 AlfredoG87 added the New Feature A new feature, service, or documentation. Major changes that are not backwards compatible. label Aug 30, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Aug 30, 2024
georgi-l95 and others added 7 commits September 3, 2024 17:20
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
…t need a provider. And refactored code around that, also divided the main entry point from the ActualApp so we can only ignore the entry point in the unit test coverage.

Added Missing unit tests

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 force-pushed the 106-create-infrastructure-for-the-simulator branch from f856f06 to ef7f0a9 Compare September 3, 2024 23:20
@AlfredoG87 AlfredoG87 marked this pull request as ready for review September 3, 2024 23:28
@AlfredoG87 AlfredoG87 requested review from a team as code owners September 3, 2024 23:28
@AlfredoG87 AlfredoG87 requested a review from rbarkerSL September 3, 2024 23:28
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've got Dagger integrated, unit tests, etc. Looks good!

Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Copy link

codecov bot commented Sep 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e957565) to head (0d9f422).

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #162   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       133       147   +14     
===========================================
  Files             27        34    +7     
  Lines            535       561   +26     
  Branches          29        29           
===========================================
+ Hits             535       561   +26     
Files with missing lines Coverage Δ
...edera/block/simulator/BlockStreamSimulatorApp.java 100.00% <100.00%> (ø)
.../block/simulator/config/ConfigInjectionModule.java 100.00% <100.00%> (ø)
...ock/simulator/config/SimulatorConfigExtension.java 100.00% <100.00%> (ø)
...block/simulator/config/data/BlockStreamConfig.java 100.00% <100.00%> (ø)
...hedera/block/simulator/config/data/GrpcConfig.java 100.00% <100.00%> (ø)
...a/block/simulator/config/types/GenerationMode.java 100.00% <100.00%> (ø)
...imulator/generator/MockBlockStreamManagerImpl.java 100.00% <100.00%> (ø)

Copy link
Contributor

@rbarkerSL rbarkerSL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving change to codecov.yml

@AlfredoG87 AlfredoG87 merged commit e392f2b into main Sep 5, 2024
12 checks passed
@AlfredoG87 AlfredoG87 deleted the 106-create-infrastructure-for-the-simulator branch September 5, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Feature A new feature, service, or documentation. Major changes that are not backwards compatible.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create infrastructure for the simulator (Producer Side)
4 participants