-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Simulator Base Project #162
Conversation
e911f55
to
37a95e8
Compare
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: georgi-l95 <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
…t need a provider. And refactored code around that, also divided the main entry point from the ActualApp so we can only ignore the entry point in the unit test coverage. Added Missing unit tests Signed-off-by: Alfredo Gutierrez <[email protected]>
f856f06
to
ef7f0a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You've got Dagger integrated, unit tests, etc. Looks good!
simulator/src/main/java/com/hedera/block/simulator/config/data/GrpcConfig.java
Outdated
Show resolved
Hide resolved
simulator/src/main/java/com/hedera/block/simulator/config/types/GenerationMode.java
Outdated
Show resolved
Hide resolved
simulator/src/main/java/com/hedera/block/simulator/generator/MockBlockStreamManagerImpl.java
Show resolved
Hide resolved
simulator/src/main/java/com/hedera/block/simulator/BlockStreamSimulatorApp.java
Show resolved
Hide resolved
simulator/src/main/java/com/hedera/block/simulator/BlockStreamSimulatorApp.java
Show resolved
Hide resolved
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #162 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 133 147 +14
===========================================
Files 27 34 +7
Lines 535 561 +26
Branches 29 29
===========================================
+ Hits 535 561 +26
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving change to codecov.yml
Description:
Related issue(s):
Fixes #106
Notes for reviewer:
The Generator section is there as a placeholder intended to change on next PR, don't pay attention to either interface, impl or test related to Generator.
Checklist