refactor: Healthz endpoints refactor #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eadiness endpoints to livez and readyz Signed-off-by: Alfredo Gutierrez <[email protected]>
AlfredoG87
force-pushed
the
healthz-endpoints-refactor
branch
from
321662d to
06f10be
Compare
AlfredoG87
added
Improvement
AlfredoG87
changed the title
Signed-off-by: Alfredo Gutierrez <[email protected]>
jsync-swirlds
approved these changes
Aug 27, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #143 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 135 135
===========================================
Files 26 26
Lines 513 511 -2
Branches 27 27
===========================================
- Hits 513 511 -2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor HealthService to use readyz and livez instead of liveness and readyness endpoints
Related issue(s):
Fixes #119
Notes for reviewer:
Checklist