-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Health endpoints #111
Conversation
Signed-off-by: Alfredo Gutierrez <[email protected]>
…ntegration with Server Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
… checks Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #111 +/- ##
===========================================
Coverage 100.00% 100.00%
- Complexity 114 121 +7
===========================================
Files 21 22 +1
Lines 430 446 +16
Branches 25 25
===========================================
+ Hits 430 446 +16
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work on the PR! A couple of comments
server/src/main/java/com/hedera/block/server/health/HealthServiceImpl.java
Outdated
Show resolved
Hide resolved
server/src/test/java/com/hedera/block/server/health/HealthServiceTest.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/health/HealthServiceImpl.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/health/HealthServiceImpl.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/health/HealthServiceImpl.java
Show resolved
Hide resolved
server/src/main/java/com/hedera/block/server/health/HealthServiceImpl.java
Show resolved
Hide resolved
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Description:
Adding Endpoints for Health
Added started completed log message as INFO.
Needed unit tests.
Related issue(s):
Fixes #67
Notes for reviewer:
Checklist