Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Health endpoints #111

Merged
merged 11 commits into from
Aug 16, 2024
Merged

feat: Health endpoints #111

merged 11 commits into from
Aug 16, 2024

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented Aug 15, 2024

Description:
Adding Endpoints for Health

  • Liveness
  • Readiness

Added started completed log message as INFO.

Needed unit tests.

Related issue(s):

Fixes #67

Notes for reviewer:

Checklist

  • Documented (Code comments, README, etc.)
  • Tested (unit, integration, etc.)

Signed-off-by: Alfredo Gutierrez <[email protected]>
…ntegration with Server

Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 self-assigned this Aug 15, 2024
@AlfredoG87 AlfredoG87 added the Improvement Code changes driven by non business requirements label Aug 15, 2024
@AlfredoG87 AlfredoG87 added this to the 0.1.0 milestone Aug 15, 2024
@AlfredoG87 AlfredoG87 changed the title feat: Healthz endpoints feat: Health endpoints Aug 15, 2024
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
@AlfredoG87 AlfredoG87 marked this pull request as ready for review August 15, 2024 18:28
@AlfredoG87 AlfredoG87 requested a review from a team as a code owner August 15, 2024 18:28
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f6fcf5b) to head (f37a287).

Additional details and impacted files
@@             Coverage Diff             @@
##                main      #111   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
- Complexity       114       121    +7     
===========================================
  Files             21        22    +1     
  Lines            430       446   +16     
  Branches          25        25           
===========================================
+ Hits             430       446   +16     
Files Coverage Δ
.../hedera/block/server/health/HealthServiceImpl.java 100.00% <100.00%> (ø)

Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work on the PR! A couple of comments

Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Signed-off-by: Alfredo Gutierrez <[email protected]>
Copy link
Contributor

@mattp-swirldslabs mattp-swirldslabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@AlfredoG87 AlfredoG87 merged commit a8bc5ec into main Aug 16, 2024
5 checks passed
@AlfredoG87 AlfredoG87 deleted the healthz-endpoints branch August 16, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Code changes driven by non business requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add healthz endpoint and readyz endpoint
2 participants