fix: editing log statements

Signed-off-by: Matt Peterson <[email protected]>
hashgraph · Aug 5, 2024 · 7411668 · 7411668
1 parent b44b41f
commit 7411668
Show file tree

Hide file tree

Showing 7 changed files with 17 additions and 13 deletions.
diff --git a/server/src/main/java/com/hedera/block/server/BlockStreamService.java b/server/src/main/java/com/hedera/block/server/BlockStreamService.java
@@ -164,7 +164,8 @@ void singleBlock(
                     singleBlockResponseStreamObserver.onNext(
                             buildSingleBlockResponse(blockOpt.get()));
                 } else {
-                    LOGGER.log(System.Logger.Level.INFO, "Block number {0} not found", blockNumber);
+                    LOGGER.log(
+                            System.Logger.Level.DEBUG, "Block number {0} not found", blockNumber);
                     singleBlockResponseStreamObserver.onNext(buildSingleBlockNotFoundResponse());
                 }
             } catch (IOException e) {

diff --git a/server/src/main/java/com/hedera/block/server/consumer/ConsumerBlockItemObserver.java b/server/src/main/java/com/hedera/block/server/consumer/ConsumerBlockItemObserver.java
@@ -80,7 +80,7 @@ public ConsumerBlockItemObserver(
                         isResponsePermitted.set(false);
                         subscriptionHandler.unsubscribe(this);
                         LOGGER.log(
-                                System.Logger.Level.INFO,
+                                System.Logger.Level.DEBUG,
                                 "Consumer cancelled stream.  Observer unsubscribed.");
                     };
             serverCallStreamObserver.setOnCancelHandler(onCancel);
@@ -92,7 +92,7 @@ public ConsumerBlockItemObserver(
                         isResponsePermitted.set(false);
                         subscriptionHandler.unsubscribe(this);
                         LOGGER.log(
-                                System.Logger.Level.INFO,
+                                System.Logger.Level.DEBUG,
                                 "Consumer completed stream.  Observer unsubscribed.");
                     };
             serverCallStreamObserver.setOnCloseHandler(onClose);

diff --git a/server/src/main/java/com/hedera/block/server/mediator/LiveStreamMediatorImpl.java b/server/src/main/java/com/hedera/block/server/mediator/LiveStreamMediatorImpl.java
@@ -126,8 +126,8 @@ public void publish(final BlockItem blockItem) throws IOException {
                 serviceStatus.setRunning(false);
                 LOGGER.log(
                         System.Logger.Level.ERROR,
-                        "An exception occurred while attempting to persist the BlockItem: {0}",
-                        blockItem,
+                        "An exception occurred while attempting to persist the BlockItem: "
+                                + blockItem,
                         e);
 
                 LOGGER.log(System.Logger.Level.INFO, "Send a response to end the stream");

diff --git a/server/src/main/java/com/hedera/block/server/persistence/storage/BlockAsDirReader.java b/server/src/main/java/com/hedera/block/server/persistence/storage/BlockAsDirReader.java
@@ -153,7 +153,8 @@ private boolean isPathDisqualified(final Path path) {
                     return true;
                 }
             } catch (IOException e) {
-                LOGGER.log(System.Logger.Level.ERROR, "Error setting permissions on: " + path, e);
+                LOGGER.log(
+                        System.Logger.Level.ERROR, "Error setting permissions on: {0}" + path, e);
                 return true;
             }
         }

diff --git a/server/src/main/java/com/hedera/block/server/persistence/storage/BlockAsDirRemover.java b/server/src/main/java/com/hedera/block/server/persistence/storage/BlockAsDirRemover.java
@@ -44,15 +44,15 @@ public void remove(final long id) throws IOException {
         // for removal
         final Path blockPath = blockNodeRootPath.resolve(String.valueOf(id));
         if (Files.notExists(blockPath)) {
-            LOGGER.log(System.Logger.Level.ERROR, "Block does not exist: " + id);
+            LOGGER.log(System.Logger.Level.ERROR, "Block does not exist: {0}", id);
             return;
         }
 
         Files.setPosixFilePermissions(blockPath, filePerms.value());
 
         // Best effort to delete the block
         if (!delete(blockPath.toFile())) {
-            LOGGER.log(System.Logger.Level.ERROR, "Failed to delete block: " + id);
+            LOGGER.log(System.Logger.Level.ERROR, "Failed to delete block: {0}", id);
         }
     }
 

diff --git a/server/src/main/java/com/hedera/block/server/persistence/storage/BlockAsDirWriter.java b/server/src/main/java/com/hedera/block/server/persistence/storage/BlockAsDirWriter.java
@@ -113,7 +113,7 @@ public void write(final BlockItem blockItem) throws IOException {
 
                 LOGGER.log(
                         System.Logger.Level.ERROR,
-                        "Error writing the BlockItem protobuf to a file",
+                        "Error writing the BlockItem protobuf to a file: ",
                         e);
 
                 // Remove the block if repairing the permissions fails
@@ -144,7 +144,9 @@ protected void write(final Path blockItemFilePath, final BlockItem blockItem)
                     blockItemFilePath);
         } catch (IOException e) {
             LOGGER.log(
-                    System.Logger.Level.ERROR, "Error writing the BlockItem protobuf to a file", e);
+                    System.Logger.Level.ERROR,
+                    "Error writing the BlockItem protobuf to a file: ",
+                    e);
             throw e;
         }
     }

diff --git a/server/src/main/java/com/hedera/block/server/producer/ProducerBlockItemObserver.java b/server/src/main/java/com/hedera/block/server/producer/ProducerBlockItemObserver.java
@@ -94,7 +94,7 @@ public void onNext(final PublishStreamRequest publishStreamRequest) {
                 } catch (IOException | NoSuchAlgorithmException e) {
                     final var errorResponse = buildErrorStreamResponse();
                     publishStreamResponseObserver.onNext(errorResponse);
-                    LOGGER.log(System.Logger.Level.ERROR, "Error calculating hash", e);
+                    LOGGER.log(System.Logger.Level.ERROR, "Error calculating hash: ", e);
                 }
 
             } else {
@@ -106,7 +106,7 @@ public void onNext(final PublishStreamRequest publishStreamRequest) {
         } catch (IOException io) {
             final var errorResponse = buildErrorStreamResponse();
             publishStreamResponseObserver.onNext(errorResponse);
-            LOGGER.log(System.Logger.Level.ERROR, "Exception thrown publishing BlockItem", io);
+            LOGGER.log(System.Logger.Level.ERROR, "Exception thrown publishing BlockItem: ", io);
 
             LOGGER.log(System.Logger.Level.ERROR, "Shutting down the web server");
             serviceStatus.stopWebServer();
@@ -136,7 +136,7 @@ private static PublishStreamResponse buildErrorStreamResponse() {
      */
     @Override
     public void onError(final Throwable t) {
-        LOGGER.log(System.Logger.Level.ERROR, "onError method invoked with an exception", t);
+        LOGGER.log(System.Logger.Level.ERROR, "onError method invoked with an exception: ", t);
         publishStreamResponseObserver.onError(t);
     }