chore: remove charts directory #993
Conversation
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #993 +/- ##
============================================
- Coverage 67.17% 67.09% -0.08%
Complexity 339 339
============================================
Files 64 64
Lines 1319 1319
Branches 157 157
============================================
- Hits 886 885 -1
- Misses 370 371 +1
Partials 63 63 see 1 file with indirect coverage changes |
Unit Test Results 26 files ±0 26 suites ±0 42s ⏱️ -5s Results for commit 056d0a2. ± Comparison against base commit 83fed7b. This pull request removes 1 test.♻️ This comment has been updated with latest results. |
…rm-charts-directory # Conflicts: # .github/CODEOWNERS # .github/workflows/flow-deploy-release-artifact.yaml # .github/workflows/support/ci/ci-values.yaml # .github/workflows/support/ci_test.sh # .github/workflows/support/scripts/env.sh # charts/fullstack-deployment/Chart.lock # charts/fullstack-deployment/values.yaml
|
|
@jeromy-cannon since Helm test workflow is removed, |
Signed-off-by: Jeffrey Tang <[email protected]>
There was a problem hiding this comment.
I think this is good to leave in for now.
| @@ -58,10 +50,6 @@ tasks.register<HelmReleaseExistsTask>("helmNginxExists") { | |||
| release.set("nginx-release") | |||
| } | |||
|
|
|||
| tasks.register<HelmDependencyUpdateTask>("helmDependencyUpdate") { | |||
There was a problem hiding this comment.
I think this is good to leave in for now. I think you can just run it on one of the other charts we already installed.
There was a problem hiding this comment.
what are the other charts installed ?
since the whole charts directory is gone
There was a problem hiding this comment.
nginx-release, but it doesn't really matter. it is just an example of how to use the gradle plugin task.
Description
This pull request changes the following:
solo-chartsrepoRelated Issues