Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove charts directory #993

Merged
merged 23 commits into from
Oct 24, 2024
Merged

Conversation

JeffreyDallas
Copy link
Contributor

@JeffreyDallas JeffreyDallas commented Oct 10, 2024

Description

This pull request changes the following:

  • Remove charts directory
  • Remove .github/workflow/support directory since the chart test is being conducted in solo-charts repo
  • Update workflow and unit tests

Related Issues

Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
@JeffreyDallas JeffreyDallas requested review from a team as code owners October 10, 2024 02:00
@JeffreyDallas JeffreyDallas self-assigned this Oct 10, 2024
Copy link

codecov bot commented Oct 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.36%. Comparing base (1a2e0ad) to head (ed28fcd).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #993      +/-   ##
============================================
+ Coverage     67.17%   67.36%   +0.19%     
  Complexity      339      339              
============================================
  Files            64       64              
  Lines          1319     1336      +17     
  Branches        157      157              
============================================
+ Hits            886      900      +14     
- Misses          370      373       +3     
  Partials         63       63              

see 7 files with indirect coverage changes

Impacted file tree graph

Copy link

github-actions bot commented Oct 10, 2024

Unit Test Results

 26 files  ±0   26 suites  ±0   42s ⏱️ -5s
109 tests ±0  105 ✅ ±0  4 💤 ±0  0 ❌ ±0 
110 runs  ±0  106 ✅ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit ed28fcd. ± Comparison against base commit 1a2e0ad.

♻️ This comment has been updated with latest results.

Base automatically changed from 00987-D-rm-container-2 to main October 10, 2024 09:46
…rm-charts-directory

# Conflicts:
#	.github/CODEOWNERS
#	.github/workflows/flow-deploy-release-artifact.yaml
#	.github/workflows/support/ci/ci-values.yaml
#	.github/workflows/support/ci_test.sh
#	.github/workflows/support/scripts/env.sh
#	charts/fullstack-deployment/Chart.lock
#	charts/fullstack-deployment/values.yaml
@JeffreyDallas
Copy link
Contributor Author

JeffreyDallas commented Oct 10, 2024

@jeromy-cannon since Helm test workflow is removed,
FS Helm Chart Tests workflow did not kick off
need your manually override to merge it

Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Signed-off-by: Jeffrey Tang <[email protected]>
Copy link

@jeromy-cannon jeromy-cannon merged commit f390d7d into main Oct 24, 2024
19 of 20 checks passed
@jeromy-cannon jeromy-cannon deleted the 00987-D-rm-charts-directory branch October 24, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove unused charts and dockers directory and files
2 participants