Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove docker #990

Closed
wants to merge 2 commits into from
Closed

chore: remove docker #990

wants to merge 2 commits into from

Conversation

JeffreyDallas
Copy link
Contributor

Description

This pull request changes the following:

  • remove docker directory
  • update workflow to remove any docker usage or dependencies

Related Issues

Part of #987

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.17%. Comparing base (d19f6cf) to head (9702965).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #990   +/-   ##
=========================================
  Coverage     67.17%   67.17%           
  Complexity      339      339           
=========================================
  Files            64       64           
  Lines          1319     1319           
  Branches        157      157           
=========================================
  Hits            886      886           
  Misses          370      370           
  Partials         63       63           

Impacted file tree graph

Copy link

github-actions bot commented Oct 9, 2024

Unit Test Results

 26 files  ±0   26 suites  ±0   47s ⏱️ -1s
109 tests ±0  105 ✅ ±0  4 💤 ±0  0 ❌ ±0 
110 runs  ±0  106 ✅ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 9702965. ± Comparison against base commit d19f6cf.

Copy link

sonarqubecloud bot commented Oct 9, 2024

@JeffreyDallas JeffreyDallas changed the title hore: remove docker and charts directory chore: remove docker and charts directory Oct 9, 2024
@JeffreyDallas JeffreyDallas changed the title chore: remove docker and charts directory chore: remove docker Oct 9, 2024
Comment on lines -62 to -67
chart-tests:
name: FS Helm Chart Tests
uses: ./.github/workflows/zxc-helm-chart-tests.yaml
with:
custom-job-label: Standard

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is not docker related.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you just removing this to avoid having to update the tests to point to the new solo container repo?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not docker related, is this being removed to avoid updates? does it still run correctly without the solo container repo changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not docker related, is this being removed to avoid updates? does it still run correctly without the solo container repo changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not docker related, is this being removed to avoid updates? does it still run correctly without the solo container repo changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not docker related, is this being removed to avoid updates? does it still run correctly without the solo container repo changes?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not docker related, is this being removed to avoid updates? does it still run correctly without the solo container repo changes?

@JeffreyDallas JeffreyDallas deleted the 00987-D-rm-container branch October 9, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants