Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): support config persistence and local chart directory for fst charts #535

Merged
merged 14 commits into from
Nov 15, 2023
Merged

feat(cli): support config persistence and local chart directory for fst charts #535

merged 14 commits into from
Nov 15, 2023

Conversation

leninmehedy
Copy link
Member

@leninmehedy leninmehedy commented Nov 14, 2023 •
edited
Loading

Description

This pull request changes the following:

  • support local chart directory for fst charts
  • allow storing command flags in a config file ~/.fsnetman/fsnetman.config
  • use -n for namespace flag instead of -s for intuitiveness
  • avoid short flags for auxiliary components(short flags are confusing and it is probably better to preserve those for later use since it may cause conflicts with widely used short flags for intuitiveness, for example -d had a conflict)

Now we can specify local chart directory as fsnetman chart install -d <PROJECT_DIR>/full-stack-testing/charts

We can also set it up once during init by running fsnetman init -d <PROJECT_DIR>/full-stack-testing/charts

config (+ flags) is cached as JSON in ~/.fsnetman/fsnetman.config as below:

❯ cat ~/.fsnetman/fsnetman.config |jq
{
  "flags": {
    "namespace": "fst-leninmehedy",
    "mirror-node": true,
    "hedera-explorer": true,
    "values-file": "",
    "chart-dir": "../../full-stack-testing/charts/"
  },
  "version": "0.1.0",
  "lastCommand": [
    "chart",
    "install"
  ],
  "updatedAt": "2023-11-14T00:19:00.450Z"
}

Related Issues

@leninmehedy leninmehedy linked an issue Nov 14, 2023 that may be closed by this pull request
CLI[Chart]: Support local chart directory for FST charts #534
Closed
@leninmehedy leninmehedy force-pushed the 534-support-local-chart-directory-for-fst-charts branch from e0bc099 to 782138a Compare November 14, 2023 00:36
@leninmehedy leninmehedy changed the title feat: support config persistence and local chart directory for fst charts feat(cli): support fsnetman config persistence and local chart directory for fst charts Nov 14, 2023
@leninmehedy leninmehedy changed the title feat(cli): support fsnetman config persistence and local chart directory for fst charts feat(cli): support config persistence and local chart directory for fst charts Nov 14, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 14, 2023 •
edited
Loading

Unit Test Results

  26 files  ±0    26 suites  ±0   1m 9s ⏱️ +9s
109 tests ±0  105 ✔️ ±0  4 💤 ±0  0 ❌ ±0 
110 runs  ±0  106 ✔️ ±0  4 💤 ±0  0 ❌ ±0 

Results for commit 3a3cde8. ± Comparison against base commit 4c7c7be.

♻️ This comment has been updated with latest results.

@leninmehedy leninmehedy self-assigned this Nov 14, 2023
@leninmehedy leninmehedy mentioned this pull request Nov 14, 2023
Merged
@leninmehedy leninmehedy marked this pull request as draft November 14, 2023 02:44
@leninmehedy leninmehedy marked this pull request as ready for review November 15, 2023 04:36
leninmehedy and others added 2 commits November 15, 2023 15:44
@leninmehedy @deepak-swirlds
chore(cli): apply eslint with standard styling (#539)
4bbbf40 
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Deepak Mishra <[email protected]>
Co-authored-by: Deepak Mishra <[email protected]>
Co-authored-by: Deepak Mishra <[email protected]>
@leninmehedy
Merge branch 'main' into 534-support-local-chart-directory-for-fst-ch…
3a3cde8 
…arts

Signed-off-by: Lenin Mehedy <[email protected]>

# Conflicts:
#	fullstack-network-manager/fsnetman.mjs
@leninmehedy
Copy link
Member Author

Need to merge as it is so that main branch has the eslintrc.yml file for Codacy to pick up.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@leninmehedy leninmehedy merged commit 73f7c1b into main Nov 15, 2023
11 of 12 checks passed
@leninmehedy leninmehedy deleted the 534-support-local-chart-directory-for-fst-charts branch November 15, 2023 05:14
@leninmehedy leninmehedy mentioned this pull request Nov 15, 2023
Closed
@swirlds-automation
Copy link
Contributor

🎉 This PR is included in version 0.13.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

swirlds-automation added a commit that referenced this pull request Nov 17, 2023
@swirlds-automation
chore(release): 0.13.0 [skip ci]
078adaf 
## [0.13.0](v0.12.0...v0.13.0) (2023-11-17)

### Features

* add a template for test labels ([#492](#492)) ([f32eaee](f32eaee))
* add cert-manager subchart to fullstack-cluster-setup Helm chart ([#493](#493)) ([674b976](674b976))
* add CI pipelines to enforce proper pull request titles ([#558](#558)) ([674ac32](674ac32))
* add envoy gateway to fullstack-cluster-setup helm chart ([#486](#486)) ([16988e4](16988e4))
* add test metadata labels for dependent charts ([#524](#524)) ([9511f1f](9511f1f))
* add test metadata to network-node-statefulset labels. ([#505](#505)) ([598eeaf](598eeaf))
* add test metadata to other resources labels ([#526](#526)) ([3762af1](3762af1))
* add test metadata to proxy resources labels ([#523](#523)) ([1067fc4](1067fc4))
* **cli:** implement node setup command ([#491](#491)) ([7920cb6](7920cb6))
* **cli:** implement package downloader and custom errors modules ([#490](#490)) ([8c143e9](8c143e9))
* **cli:** support config persistence and local chart directory for fst charts ([#535](#535)) ([73f7c1b](73f7c1b))
* implement node start and stop commands ([#520](#520)) ([9883fa7](9883fa7))

### Bug Fixes

* **chart:** use quote for test labels and fix e2e tests  ([#560](#560)) ([27fda90](27fda90))
* **cli:** init command should add FST helm chart repository ([#527](#527)) ([dc1e748](dc1e748))
* **cli:** invoke helm dependency update when local chart-dir is set ([#562](#562)) ([38dd176](38dd176))
* **cli:** kubectl version command errors out if server is un reachable ([#529](#529)) ([85ac118](85ac118))
* ensure Node package definitions are committed during a release ([#538](#538)) ([cbabf85](cbabf85))
* set namespace to kubectl context after cluster create ([#521](#521)) ([803ee4b](803ee4b))
* use correct variable name to check platform version ([#503](#503)) ([460a68e](460a68e))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codacy-production codacy-production[bot] codacy-production[bot] left review comments

@nathanklick nathanklick nathanklick approved these changes

@jeromy-cannon jeromy-cannon Awaiting requested review from jeromy-cannon

@qnswirlds qnswirlds Awaiting requested review from qnswirlds

Assignees

@leninmehedy leninmehedy

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI[Chart]: Support local chart directory for FST charts CLI[Cluster]: Use -n for namespace arg
3 participants
@leninmehedy @swirlds-automation @nathanklick