-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use correct variable name to check platform version #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leninmehedy
changed the title
fix: use PLATFORM_VERSION variable instead of PLATFORM_PROFILE
fix: use correct variable name to check platform version
Nov 9, 2023
jeromy-cannon
approved these changes
Nov 9, 2023
leninmehedy
commented
Nov 10, 2023
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
Signed-off-by: Lenin Mehedy <[email protected]>
leninmehedy
force-pushed
the
fix-makefile-script
branch
from
November 13, 2023 04:15
8fe0965
to
7164af3
Compare
Kudos, SonarCloud Quality Gate passed! |
swirlds-automation
added a commit
that referenced
this pull request
Nov 17, 2023
## [0.13.0](v0.12.0...v0.13.0) (2023-11-17) ### Features * add a template for test labels ([#492](#492)) ([f32eaee](f32eaee)) * add cert-manager subchart to fullstack-cluster-setup Helm chart ([#493](#493)) ([674b976](674b976)) * add CI pipelines to enforce proper pull request titles ([#558](#558)) ([674ac32](674ac32)) * add envoy gateway to fullstack-cluster-setup helm chart ([#486](#486)) ([16988e4](16988e4)) * add test metadata labels for dependent charts ([#524](#524)) ([9511f1f](9511f1f)) * add test metadata to network-node-statefulset labels. ([#505](#505)) ([598eeaf](598eeaf)) * add test metadata to other resources labels ([#526](#526)) ([3762af1](3762af1)) * add test metadata to proxy resources labels ([#523](#523)) ([1067fc4](1067fc4)) * **cli:** implement node setup command ([#491](#491)) ([7920cb6](7920cb6)) * **cli:** implement package downloader and custom errors modules ([#490](#490)) ([8c143e9](8c143e9)) * **cli:** support config persistence and local chart directory for fst charts ([#535](#535)) ([73f7c1b](73f7c1b)) * implement node start and stop commands ([#520](#520)) ([9883fa7](9883fa7)) ### Bug Fixes * **chart:** use quote for test labels and fix e2e tests ([#560](#560)) ([27fda90](27fda90)) * **cli:** init command should add FST helm chart repository ([#527](#527)) ([dc1e748](dc1e748)) * **cli:** invoke helm dependency update when local chart-dir is set ([#562](#562)) ([38dd176](38dd176)) * **cli:** kubectl version command errors out if server is un reachable ([#529](#529)) ([85ac118](85ac118)) * ensure Node package definitions are committed during a release ([#538](#538)) ([cbabf85](cbabf85)) * set namespace to kubectl context after cluster create ([#521](#521)) ([803ee4b](803ee4b)) * use correct variable name to check platform version ([#503](#503)) ([460a68e](460a68e))
🎉 This PR is included in version 0.13.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Related Issues