fix: add release name as prefix to chart resource names during deployment #392
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
Below screenshot shows an example deployment with
RELEASE_NAME=fst
:Limitations:
I started working on this with the anticipation that this could allow deploying FST chart multiple times in the same namespace. For example, if a user has access to a single namespace, he/she could deploy the FST chart multiple times in the same namespace for different test scenario and avoid the explosion namespaces in the shared cluster.
However, it appears dependent charts e.g. mirror-node creates some secrets without release name prefix (e.g. it creates "mirror-passwords" instead of "{{.Release.Name}}-mirror-passwords)", so it blocks us from deploying the chart multiple times in the same namespace)
So at the end this PR doesn't add much value except the fact that it is now consistent with mirror-node resource naming. However, if mirror-node updates their secrets with release name prefix, we would be able to deploy the same chart multiple times for different test scenario and avoid the "namespace explosion" in the cluster...
Related Issues