-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add helm dependency update subcommand #377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromy-cannon
force-pushed
the
00306-helm-client-dependency-update
branch
from
October 2, 2023 18:08
a7dd082
to
7fe0aae
Compare
jeromy-cannon
requested review from
nathanklick,
deepak-swirlds and
leninmehedy
October 2, 2023 20:30
jeromy-cannon
force-pushed
the
00305-helm-client-test-subcommand
branch
2 times, most recently
from
October 4, 2023 15:28
5861de4
to
65eb5fe
Compare
jeromy-cannon
force-pushed
the
00306-helm-client-dependency-update
branch
from
October 4, 2023 15:35
5eb36bf
to
6e1d67b
Compare
leninmehedy
approved these changes
Oct 4, 2023
jeromy-cannon
force-pushed
the
00305-helm-client-test-subcommand
branch
from
October 5, 2023 13:40
65eb5fe
to
572e900
Compare
jeromy-cannon
force-pushed
the
00306-helm-client-dependency-update
branch
from
October 5, 2023 13:42
6e1d67b
to
61f48a9
Compare
commit 5eb36bf Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 21:30:37 2023 +0100 remove public modifier Signed-off-by: Jeromy Cannon <[email protected]> commit a18cfa8 Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 20:45:40 2023 +0100 more test coverage Signed-off-by: Jeromy Cannon <[email protected]> commit 05592cb Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 20:38:43 2023 +0100 removed system out println Signed-off-by: Jeromy Cannon <[email protected]> commit e1cac52 Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 20:37:02 2023 +0100 increase test coverage Signed-off-by: Jeromy Cannon <[email protected]> commit 57770ee Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 20:36:51 2023 +0100 added workingDirectory override abilities into helm client for using within test cases Signed-off-by: Jeromy Cannon <[email protected]> commit 7fe0aae Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 19:02:55 2023 +0100 added helm client dependency update Signed-off-by: Jeromy Cannon <[email protected]> commit 5f4d57c Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 19:05:28 2023 +0100 fix failing test case Signed-off-by: Jeromy Cannon <[email protected]> commit d61a652 Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 16:53:14 2023 +0100 test coverage Signed-off-by: Jeromy Cannon <[email protected]> commit d813231 Author: Jeromy Cannon <[email protected]> Date: Fri Sep 29 16:58:16 2023 +0100 testChart(String releaseName, TestChartOptions options) Signed-off-by: Jeromy Cannon <[email protected]> commit c7aaf6c Author: Jeromy Cannon <[email protected]> Date: Thu Sep 28 19:54:15 2023 +0100 HelmUninstallChartTask code/examples/test coverage Signed-off-by: Jeromy Cannon <[email protected]> commit 6240d28 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 27 17:18:35 2023 +0100 fix test case failure Signed-off-by: Jeromy Cannon <[email protected]> commit 4a51c38 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 27 14:47:16 2023 +0100 removed todo for gradle plugin logging if error and added coverage for the same Signed-off-by: Jeromy Cannon <[email protected]> commit 834586d Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 21:15:39 2023 +0100 gradle-executable path provided Signed-off-by: Jeromy Cannon <[email protected]> commit c2cbdbf Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 20:52:32 2023 +0100 gradle-executable path provided Signed-off-by: Jeromy Cannon <[email protected]> commit a7540dc Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 18:35:14 2023 +0100 gradle-executable shouldn't be needed... Signed-off-by: Jeromy Cannon <[email protected]> commit 480c288 Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 18:12:35 2023 +0100 supply gradle executable directory for new jobs Signed-off-by: Jeromy Cannon <[email protected]> commit 719b24b Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 18:03:21 2023 +0100 supply gradle executable directory for new jobs Signed-off-by: Jeromy Cannon <[email protected]> commit 67e9c1c Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 17:39:47 2023 +0100 Examples Spotless Check Signed-off-by: Jeromy Cannon <[email protected]> commit 9c40db5 Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 17:35:06 2023 +0100 update job ids for new jobs Signed-off-by: Jeromy Cannon <[email protected]> commit c80aa8b Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 17:31:18 2023 +0100 add compile and unit test jobs for examples project since they are now separate Signed-off-by: Jeromy Cannon <[email protected]> commit 4475c6a Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 17:21:14 2023 +0100 updates based on feedback from Jendrick on hedera-services changes. Signed-off-by: Jeromy Cannon <[email protected]> commit dd90490 Author: Jeromy Cannon <[email protected]> Date: Tue Sep 26 09:41:51 2023 +0100 updates based on changes in helm install subcommand Signed-off-by: Jeromy Cannon <[email protected]> commit 6f436e6 Author: Jeromy Cannon <[email protected]> Date: Mon Sep 25 14:42:22 2023 +0100 temporarily disable fullstack-examples until we can resolve intellij and sonar issues Signed-off-by: Jeromy Cannon <[email protected]> commit 962080e Author: Jeromy Cannon <[email protected]> Date: Fri Sep 22 20:12:30 2023 +0100 Squashed commit of the following: commit d177c82 Author: Jeromy Cannon <[email protected]> Date: Thu Sep 21 19:02:43 2023 +0100 updated HelmExecutionBuilder workingDirectory to use PWD instead of new File('.') from FileUtils Signed-off-by: Jeromy Cannon <[email protected]> commit 7ef57c1 Author: Jeromy Cannon <[email protected]> Date: Thu Sep 21 14:09:23 2023 +0100 removed commented out code that was previously used for shadowjars Signed-off-by: Jeromy Cannon <[email protected]> commit 4891dd5 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 20:02:40 2023 +0100 remove shadowjars Signed-off-by: Jeromy Cannon <[email protected]> commit 9d67a54 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 19:48:24 2023 +0100 remove shadowjars Signed-off-by: Jeromy Cannon <[email protected]> commit 3dc75a0 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 19:43:55 2023 +0100 todo Signed-off-by: Jeromy Cannon <[email protected]> commit 7660afb Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 19:42:46 2023 +0100 more todo's Signed-off-by: Jeromy Cannon <[email protected]> commit 51df393 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 18:04:31 2023 +0100 switch to a different repo to avoid test collisions Signed-off-by: Jeromy Cannon <[email protected]> commit 44754c1 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 17:35:19 2023 +0100 remove code smells Signed-off-by: Jeromy Cannon <[email protected]> commit d068f26 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 16:25:05 2023 +0100 updated HelmInstallChartTaskTest to different chart/repo to avoid collisions with other tests Signed-off-by: Jeromy Cannon <[email protected]> commit 7821d6f Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 13:10:07 2023 +0100 add licenses at top of kotlin files Signed-off-by: Jeromy Cannon <[email protected]> commit ae3d3c7 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 13:02:06 2023 +0100 added TODO Signed-off-by: Jeromy Cannon <[email protected]> commit 4a82261 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 12:53:04 2023 +0100 Revert "removed unneeded test implementation reference" This reverts commit 8eedff9. Signed-off-by: Jeromy Cannon <[email protected]> commit 674c155 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 12:49:28 2023 +0100 removed unneeded test implementation reference Signed-off-by: Jeromy Cannon <[email protected]> commit 23c3104 Author: Jeromy Cannon <[email protected]> Date: Wed Sep 20 12:45:25 2023 +0100 upcoming todo for next PR Signed-off-by: Jeromy Cannon <[email protected]> commit 72bf7b3 Author: Jeromy Cannon <[email protected]> Date: Tue Sep 19 22:26:19 2023 +0100 removed commented out code Signed-off-by: Jeromy Cannon <[email protected]> commit aec75d3 Author: Jeromy Cannon <[email protected]> Date: Tue Sep 19 22:24:54 2023 +0100 FileUtils.getWorkingPath() Signed-off-by: Jeromy Cannon <[email protected]> commit 50e2a0e Author: Jeromy Cannon <[email protected]> Date: Tue Sep 19 22:21:05 2023 +0100 remove commented out code Signed-off-by: Jeromy Cannon <[email protected]> commit 659283b Author: Jeromy Cannon <[email protected]> Date: Tue Sep 19 22:20:56 2023 +0100 remove commented out code Signed-off-by: Jeromy Cannon <[email protected]> commit 5fb6e86 Author: Jeromy Cannon <[email protected]> Date: Tue Sep 19 22:20:30 2023 +0100 added namespace and create namespace and example chart for installing during build check Signed-off-by: Jeromy Cannon <[email protected]> commit 6102441 Author: Jeromy Cannon <[email protected]> Date: Mon Sep 18 19:44:36 2023 +0100 working version Signed-off-by: Jeromy Cannon <[email protected]> commit 7e06feb Author: Jeromy Cannon <[email protected]> Date: Mon Sep 18 19:29:05 2023 +0100 task working Signed-off-by: Jeromy Cannon <[email protected]> commit 19c176b Author: Jeromy Cannon <[email protected]> Date: Mon Sep 18 19:06:37 2023 +0100 non-working version Signed-off-by: Jeromy Cannon <[email protected]> commit 9e2e66f Author: Jeromy Cannon <[email protected]> Date: Mon Sep 18 17:01:59 2023 +0100 compiling version although not executing of moving integration tests into examples Signed-off-by: Jeromy Cannon <[email protected]> commit c5a9b8a Author: Jeromy Cannon <[email protected]> Date: Fri Sep 15 18:30:00 2023 +0100 added logic to set the namespace in the helm install task Signed-off-by: Jeromy Cannon <[email protected]> commit dc85197 Author: Jeromy Cannon <[email protected]> Date: Fri Sep 15 17:47:30 2023 +0100 removed duplicate export Signed-off-by: Jeromy Cannon <[email protected]> commit 6710059 Author: Jeromy Cannon <[email protected]> Date: Fri Sep 15 17:28:10 2023 +0100 added support for set and values parameters of install subcommand to handle sets Signed-off-by: Jeromy Cannon <[email protected]> commit 0d49686 Author: Jeromy Cannon <[email protected]> Date: Fri Sep 15 17:27:21 2023 +0100 enhanced helm client to handle sets of strings for values and set parameters for the install subcommand Signed-off-by: Jeromy Cannon <[email protected]> commit 3f634e0 Author: Jeromy Cannon <[email protected]> Date: Thu Sep 14 19:39:03 2023 +0100 test nmt install Signed-off-by: Jeromy Cannon <[email protected]> commit a760d52 Author: Jeromy Cannon <[email protected]> Date: Thu Sep 14 19:06:12 2023 +0100 update version from 0.7.0 to 0.8.0 Signed-off-by: Jeromy Cannon <[email protected]> commit 3c2a99b Author: Jeromy Cannon <[email protected]> Date: Thu Sep 14 19:04:34 2023 +0100 todo Signed-off-by: Jeromy Cannon <[email protected]> commit 77c59ef Author: Jeromy Cannon <[email protected]> Date: Thu Sep 14 18:57:51 2023 +0100 removed comment from FullstackPlugin.java Signed-off-by: Jeromy Cannon <[email protected]> commit 840f64b Author: Jeromy Cannon <[email protected]> Date: Thu Sep 14 18:56:19 2023 +0100 reordered alphabetically Signed-off-by: Jeromy Cannon <[email protected]> commit 28005ad Author: Jeromy Cannon <[email protected]> Date: Thu Sep 14 18:53:54 2023 +0100 added set parameter Signed-off-by: Jeromy Cannon <[email protected]> commit 1d03540 Author: Jeromy Cannon <[email protected]> Date: Thu Sep 14 18:32:07 2023 +0100 update after merge from main made a mess (part2) Signed-off-by: Jeromy Cannon <[email protected]> commit bb254c6 Author: Jeromy Cannon <[email protected]> Date: Thu Sep 14 18:26:36 2023 +0100 update after merge from main made a mess Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]> commit 7c5b663 Author: Jeromy Cannon <[email protected]> Date: Mon Oct 2 17:07:26 2023 +0100 better rename for options with multiple values Signed-off-by: Jeromy Cannon <[email protected]> commit db5283d Author: Jeromy Cannon <[email protected]> Date: Mon Sep 25 21:45:18 2023 +0100 updates based on code review Signed-off-by: Jeromy Cannon <[email protected]> commit 72757ac Author: Jeromy Cannon <[email protected]> Date: Mon Sep 25 13:40:35 2023 +0100 sonar changes Signed-off-by: Jeromy Cannon <[email protected]> commit d1b70f8 Author: Jeromy Cannon <[email protected]> Date: Fri Sep 22 19:55:41 2023 +0100 coverage for ChartInstallRequest.apply() Signed-off-by: Jeromy Cannon <[email protected]> commit 622fd31 Author: Jeromy Cannon <[email protected]> Date: Fri Sep 22 19:55:13 2023 +0100 spotlessApply Signed-off-by: Jeromy Cannon <[email protected]> commit 25ca488 Author: Jeromy Cannon <[email protected]> Date: Fri Sep 22 18:55:38 2023 +0100 only %n for string.format Signed-off-by: Jeromy Cannon <[email protected]> commit c9c45f9 Author: Jeromy Cannon <[email protected]> Date: Thu Sep 21 20:26:55 2023 +0100 GMD: Enhance Helm Install to support multiple set and values parameters #366 Signed-off-by: Jeromy Cannon <[email protected]> Signed-off-by: Jeromy Cannon <[email protected]>
jeromy-cannon
force-pushed
the
00306-helm-client-dependency-update
branch
from
October 5, 2023 16:09
61f48a9
to
7bf3982
Compare
Kudos, SonarCloud Quality Gate passed! |
swirlds-automation
added a commit
that referenced
this pull request
Nov 3, 2023
## [0.12.0](v0.11.0...v0.12.0) (2023-11-03) ### Features * add a Gradle task for downloading executable for Kubernetes Kind ([#425](#425)) ([aaa9660](aaa9660)) * add fullstack-gradle-plugin project to GitHub workflow ([#421](#421)) ([7b717ab](7b717ab)) * add Gateway API route for Hedera Explorer ([#466](#466)) ([c53943c](c53943c)) * add Gradle build docker image tasks ([#408](#408)) ([338cf40](338cf40)) * add gradle Helm dependency update task ([#393](#393)) ([8e3ead5](8e3ead5)) * add gradle Helm release exists task ([#389](#389)) ([0b7ae17](0b7ae17)) * add gradle Helm test task ([#403](#403)) ([591cebb](591cebb)) * add helm chart tests for gateway api routes ([#345](#345)) ([3936a64](3936a64)) * add helm dependency update subcommand ([#377](#377)) ([2b3609d](2b3609d)) * add helm execution gradle task: HelmInstallChartTask ([#304](#304)) ([6a29222](6a29222)) * add helm execution gradle task: HelmUninstallChartTask ([#375](#375)) ([ba6cc63](ba6cc63)) * add helm list releases subcommand ([#380](#380)) ([53d092f](53d092f)) * add helm test subcommand with options ([#376](#376)) ([5d08a32](5d08a32)) * add ifExists option to Gradle Helm uninstall task ([#405](#405)) ([0726725](0726725)) * add minio operator to fullstack-cluster-setup chart ([#453](#453)) ([bf7f6ff](bf7f6ff)) * add prometheus operator to fullstack-cluster-setup ([#460](#460)) ([0313c3a](0313c3a)) * add skipIfExists option for Gradle Helm install task ([#406](#406)) ([ccfbabf](ccfbabf)) * add support for scheduling pods based on node labels, taints, and affinity ([#352](#352)) ([5dd625a](5dd625a)) * Adding fabric8 k8s library and helm client for use in Infra API ([#386](#386)) ([3049fe4](3049fe4)) * Adding topology model classes and junit annotation processing ([#383](#383)) ([9c6930e](9c6930e)) * apply nodeSelector and tolerations to all pods including proxies ([#384](#384)) ([40e737a](40e737a)) * **cli:** add traceId in CLI logs for easier debugging ([#449](#449)) ([a1693c7](a1693c7)) * **cli:** implement chart install, uninstall and upgrade commands ([#454](#454)) ([70fd199](70fd199)) * **cli:** implement cluster create and delete commands ([#446](#446)) ([78be823](78be823)) * **cli:** implement cluster setup command ([#452](#452)) ([89c2662](89c2662)) * **cli:** implement tests and dependency checks for init command ([#438](#438)) ([b69dd99](b69dd99)) * enhance Helm Install to support multiple set and values parameters ([#367](#367)) ([05444df](05444df)) * implement fullstack-cluster-setup chart for shared resources ([#363](#363)) ([e91f465](e91f465)) * parameterize the helm chart namespace value ([#351](#351)) ([6d1c0a5](6d1c0a5)) * scaffold fsnetman CLI with ES6 support ([#424](#424)) ([65e06d9](65e06d9)) * upgrade to gradle 8.4 ([#404](#404)) ([69e769d](69e769d)) * upgrade to org.gradlex:java-module-dependencies:1.4.1 ([#365](#365)) ([ba7c32b](ba7c32b)) ### Bug Fixes * avoid hardcoding mirror-node-explorer rest API in values.yaml ([#413](#413)) ([0fe58c7](0fe58c7)) * **cli:** encapsulate helm and kubectl commands and code cleanup ([#476](#476)) ([1b8c499](1b8c499)) * **cli:** encapsulate Kind commands in a separate wrapper class ([#468](#468)) ([6dc6025](6dc6025)) * store hedera-explorer chart as dependency until next official version is released ([#436](#436)) ([201bda5](201bda5)) * support deploying the chart with custom release name ([#412](#412)) ([619b42b](619b42b)) * uninstall envoy-gateway should also remove gateway-system namespace that it created ([#350](#350)) ([8a2f6e1](8a2f6e1)) * update KeyValuePair.equals to only compare key (not value) ([#347](#347)) ([28222e0](28222e0))
🎉 This PR is included in version 0.12.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request changes the following:
PR Walkthrough (4 minutes): https://www.loom.com/share/239d457b687b4ffdaf18037dd3c77161?sid=d38361c3-8b79-4ba8-9d22-2c3d394d696f
Related Issues