Skip to content

Commit

Permalink
ci: cleanup makefile targets
Browse files Browse the repository at this point in the history
  • Loading branch information
leninmehedy committed Oct 4, 2023
1 parent 26904a6 commit be768f3
Showing 1 changed file with 3 additions and 17 deletions.
20 changes: 3 additions & 17 deletions dev/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -236,12 +236,8 @@ destroy-test-container:
local-kubectl-bats:
source "${SCRIPTS_DIR}/${DOCKER_SCRIPT}" && build_kubectl_bats "${CLUSTER_NAME}"

# Here we run all steps in sequence, if any step fails, deploy-all trap the EXIT and run cleanup
.PHONY: run-deploy-seq
run-deploy-seq: setup deploy-network helm-test setup-nodes start-nodes

.PHONY: deploy-all
deploy-all:
.PHONY: ci-test
ci-test:
# Enable cleanup_test function so that even if test fails, we cleanup the cluster.
# We are only enabling this in this make target, however if necessary, similar pattern can be used in other targets.
# Ref: https://stackoverflow.com/questions/28597794/how-can-i-clean-up-after-an-error-in-a-makefile
Expand All @@ -250,17 +246,7 @@ deploy-all:
$(MAKE) destroy-network
}
trap cleanup_test EXIT # always destroy-network on exit
$(MAKE) run-deploy-seq

.PHONY: destroy-all
destroy-all:
-$(MAKE) destroy-network
-$(MAKE) undeploy-minio-operator
-$(MAKE) destroy-prometheus-operator

.PHONY: ci-test
ci-test: setup-cluster local-kubectl-bats
$(MAKE) deploy-all CHART_VALUES_FILES="$(PWD)/ci/ci-values.yaml"
$(MAKE) ci-deploy-network setup-nodes start-nodes

.PHONY: ci-deploy-network
ci-deploy-network: setup-cluster local-kubectl-bats
Expand Down

0 comments on commit be768f3

Please sign in to comment.