fix: update KeyValuePair.equals to only compare key (not value) (#347)

Signed-off-by: Jeromy Cannon <[email protected]>
hashgraph · Sep 15, 2023 · 28222e0 · 28222e0
1 parent 208cf55
commit 28222e0
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/fullstack-base-api/src/main/java/com/hedera/fullstack/base/api/collections/KeyValuePair.java b/fullstack-base-api/src/main/java/com/hedera/fullstack/base/api/collections/KeyValuePair.java
@@ -47,7 +47,7 @@ public static <K, V> KeyValuePair<K, V> of(final K key, final V value) {
     public boolean equals(final Object o) {
         if (this == o) return true;
         if (!(o instanceof KeyValuePair<?, ?> that)) return false;
-        return Objects.equals(key, that.key) && Objects.equals(value, that.value);
+        return Objects.equals(key, that.key);
     }
 
     @Override

diff --git a/...se-api/src/test/java/com/hedera/fullstack/base/api/test/collections/KeyValuePairTest.java b/...se-api/src/test/java/com/hedera/fullstack/base/api/test/collections/KeyValuePairTest.java
@@ -28,7 +28,7 @@ public class KeyValuePairTest {
     void testKeyValuePair() {
         KeyValuePair<String, String> kvp1 = new KeyValuePair<>("key", "value");
         KeyValuePair<String, String> kvp1v2 = new KeyValuePair<>("key", "value2");
-        assertThat(kvp1).isNotEqualTo(kvp1v2);
+        assertThat(kvp1).isEqualTo(kvp1v2);
         assertThat(kvp1.hashCode()).isEqualTo(kvp1v2.hashCode());
     }
 }