Add patch to build sharedlibs on cygwin #976
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n trying to hack it in after the fact.
|
Note, the issue is also fixed upstream via zeromq/libzmq#1283 in libzmq v4.2. |
|
+1. Thanks! |
|
Did you run into any problems with the call to config.sub in the configure script? I tried some testing on cygwin and several autotools packages seem to be failing at that step. |
|
I haven't yet run into any problems with Just as a heads up, I have a big patch for Python coming soon too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adapts the patch from http://trac.sagemath.org/ticket/17333 to allow libtool to make the shared lib in the first place rather than trying to hack it together after libtool is run. While maintaining patches is always unfortunate this should be more reliable. Fixes #367 and hashdist/hashdist#367