Skeleton VM for StoffelMPC #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the MPCType trait
…rcuits, added common.rs for instructions common to both GC and Arithmetic circuits
th4s
reviewed
Jan 19, 2022
vm/src/state.rs
Outdated
Comment on lines
10
to
16
| pub(crate) struct Register<T: MPCType>(Vec<T>); | ||
|
|
||
| #[derive(Clone, Debug, Default)] | ||
| pub(crate) struct StackRegister<T: MPCType>(Vec<T>); | ||
|
|
||
| #[derive(Clone, Debug)] | ||
| pub(crate) struct Memory<T: MPCType, const N: usize>([T; N]); |
There was a problem hiding this comment.
Hmm, so normally pub is more open than pub(crate).
If there is a pub-"path" to some function/struct/enum you can use it in other modules, and even in other crates. The pub(crate) restricts it to just this crate and it is then not usable in other crates.
Co-authored-by: th4s <[email protected]>
- Now able to create a stoffelVM instance - Added some README example
and added once crate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started filling out some basics of what behaviors the MPC VM for Stoffel should have. Since there is very little documentation on how the VMs of SCALE-MAMBA and MP-SPDZ behave, we will need to both grok how those operate and then make suitable software engineering decisions on how we will implement them. This PR is mainly for defining the high-level behavior so that we can focus on deeper behaviors as we start to understand how MPC VMs work.
I have opened several issues in which we can discuss implementation details and how they might change due to the needs of MPC, namely #21.