[stack-base] fix issue building gitea #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnaulty
force-pushed
the
jnaulty/update-npm-stack-base
branch
2 times, most recently
from
602f831
to
12b507d
Compare
jnaulty
changed the title
jnaulty
commented
Nov 29, 2020
make/images.mk
Outdated
| @@ -101,6 +101,7 @@ images/gitea.tar: images/gitea images/stack-go.tar images/git.tar | |||
| docker load -i images/stack-go.tar | |||
| docker load -i images/git.tar | |||
| docker build \ | |||
| --no-cache \ | |||
There was a problem hiding this comment.
will remove this line, it was just making my life easier for testing
jnaulty
force-pushed
the
jnaulty/update-npm-stack-base
branch
2 times, most recently
from
60ca5da
to
731e0f5
Compare
Use `debian-backports` to update npm from `5.8.0+ds6-4+deb10u2` to `6.14.8+ds-1~bpo10+1`. Why: To help fix an issue encountered when building the `images/gitea.tar` artifact, which was failing to build because of an npm install error. See hashbang#4 for more information. What/How: Add backported packages from the debian-backports repository to build with a newer version of npm. Resolved issue by following the documented debian backport instructions: https://backports.debian.org/Instructions/ and adding the repos to the `update-packages.sh` script NPM Package References: - buster npm package: https://packages.debian.org/buster/npm - buster-backports npm package: https://packages.debian.org/buster-backports/npm Testing: - clean images `rm -f images/*.tar` - build image: `make images/gitea.tar` - verify image builds :)
jnaulty
force-pushed
the
jnaulty/update-npm-stack-base
branch
from
731e0f5
to
02975d9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
debian-backportsto update npm from5.8.0+ds6-4+deb10u2to6.14.8+ds-1~bpo10+1.Why:
To help fix an issue encountered when building the
images/gitea.tarartifact,which was failing to build because of an npm install error.
See #4 for more information.
What/How:
Add backported packages from the debian-backports repository to build
with a newer version of npm.
Resolved issue by following the documented debian backport instructions:
https://backports.debian.org/Instructions/
NPM Package References:
Testing:
rm -f images/*.tarmake images/gitea.tarFixes #4