This repository has been archived by the owner on Feb 16, 2022. It is now read-only.
Fix gpg signature generation for tag and simplify signed data #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daurnimator
reviewed
May 2, 2021
| git -c diff.indentHeuristic=false diff-tree -p "$1"..HEAD \ | ||
| | git patch-id --stable \ | ||
| | cut -d' ' -f1 | ||
| printf "%s" "$(git show-ref "$1" -s)" |
There was a problem hiding this comment.
In such a way, I would like to sign the object ID without the new line character.
- Use tag object ID instead of head commit as git note object ID - Use note object ID as signed data
alexey-igrychev
force-pushed
the
fix_gpg_signature_generation_for_tag
branch
from
1a205c2
to
64b05ac
Compare
|
@daurnimator First of all, thank you very much for the repository and ready-to-use workflow. I want to integrate this utility (and approach in general) with other tools to organize internal processes. |
|
@daurnimator I apologize for the direct appeal, but could you please give feedback. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The creation of this PR is motivated by the lack of tagging support (it is possible to sign a linked commit) and the overly complicated data that is signed.
It is suggested to use object ID (commit ID or tag object ID) instead of HEAD commit ID as the git note object ID.
It is also proposed to use object ID as the data to be signed. In this case, verification is simplified and the user does not need to use a utility for verification (the user can implement the verification with whatever, wherever and however he wants).
These changes break compatibility with previous versions and the version must be changed.