bump: harvester/webhook to v0.1.4 #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yu-Jack
changed the title
Signed-off-by: Jack Yu <[email protected]>
Yu-Jack
force-pushed
the
fix-42-bump-0.1.3
branch
from
29250da to
c15c6b8
Compare
Yu-Jack
requested review from
bk201,
starbops and
ibrokethecloud
and removed request for
bk201,
starbops and
ibrokethecloud
Yu-Jack
changed the title
Yu-Jack
changed the title
Signed-off-by: Jack Yu <[email protected]>
bk201
reviewed
Jan 19, 2024
bk201
reviewed
Jan 19, 2024
| admissionregv1 "k8s.io/api/admissionregistration/v1" | ||
| "k8s.io/apimachinery/pkg/labels" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
|
|
||
| "github.com/harvester/webhook/pkg/server/admission" |
pkg/webhook/nad/mutator.go
Outdated
| cniv1 "github.com/k8snetworkplumbingwg/network-attachment-definition-client/pkg/apis/k8s.cni.cncf.io/v1" | ||
| "github.com/tidwall/sjson" | ||
| admissionregv1 "k8s.io/api/admissionregistration/v1" | ||
| k8slabels "k8s.io/apimachinery/pkg/labels" | ||
| "k8s.io/apimachinery/pkg/runtime" | ||
| "k8s.io/klog" | ||
|
|
||
| "github.com/harvester/webhook/pkg/server/admission" |
Signed-off-by: Jack Yu <[email protected]>
Yu-Jack
force-pushed
the
fix-42-bump-0.1.3
branch
from
8cda15a to
df0b1b9
Compare
starbops
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solution:
Wait for this PR harvester/webhook#6
Related Issue:
https://github.com/harvester/security/issues/42
Additional Context
webhook/pkg at v0.1.2 · harvester/webhook v.s webhook/pkg at v0.1.3 · harvester/webhook, there are some unsupported package in webhook 0.1.3, such as types
Result
Check this comment to see result.