Use VMCache instead of VMICache to judge if the NAD is in use #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mingshuoqiu can you also add steps in Testplan for verifying deletion of vlan config as well with stopped vm. |
rrajendran17
reviewed
Dec 5, 2024
| @@ -218,20 +217,13 @@ func (v *Validator) checkVmi(vc *networkv1.VlanConfig, nodes mapset.Set[string]) | |||
| } | |||
There was a problem hiding this comment.
since NAD deletion is validating for the presence of stopped vms, vlan config deletion could just validate the presence of NADs attached to the cluster network.Checking the presence of vms again could be redundant in vlanconfig deletion
pkg/webhook/nad/validator.go
Outdated
| @@ -135,7 +138,7 @@ func (v *Validator) checkVmi(nad *cniv1.NetworkAttachmentDefinition) error { | |||
| if len(vmis) > 0 { | |||
| vmiNameList := make([]string, 0, len(vmis)) | |||
| for _, vmi := range vmis { | |||
| vmiNameList = append(vmiNameList, vmi.Namespace+"/"+vmi.Name) | |||
| vmiNameList = append(vmiNameList, vmi) | |||
| } | |||
| return fmt.Errorf("it's still used by VM(s) %s which must be stopped at first", strings.Join(vmiNameList, ", ")) | |||
There was a problem hiding this comment.
Error msg should be different for update and delete case.
"It is still used by vms, vms must be stopped first" - for update NAD
"nad cannot be deleted as it is still attached to vms" - for delete NAD
mingshuoqiu
force-pushed
the
issue_6961
branch
2 times, most recently
from
bdf0dbd to
bec79e5
Compare
The VMI status will be none if the VM is turned off from the GUI. The VMI information can't not be relied to make sure if particular NAD is attched to any VM or not. Use VMCache instead to prevent from deleting the NAD if the VM is turned off. Signed-off-by: Chris Chiu <[email protected]>
mingshuoqiu
force-pushed
the
issue_6961
branch
from
bec79e5 to
1477278
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The VMI status will be none if the VM is turned off from the GUI. The VMI information can't not be relied to make sure if particular NAD is attched to any VM or not. Use VMCache instead to prevent from deleting the NAD if the VM is turned off.
Problem:
Fail to delete an Off VM if its network was deleted. The VM network can be deleted if the attached VM is off. It will be a problem if user try to turn the VM back to on.
Solution:
Do not allow VM network removing if the VM still exists, even it is OFF.
Related Issue:
harvester/harvester#6961
Test plan: