2995 check if storage network attached before cluster network and vlan config config deletion

[rrajendran17]

Problem:
1.User can delete the cluster network when storage network NAD is still attached to it.
2.User can delete the vlan config when storage network NAD is still attached to it.

The above breaks the networking functionality of storage networks without user being notified.

Solution:
Do not delete the cluster network or vlan config if storage network still exists for the cluster.

Related Issue:

Test plan:
Manually validated in a harvester node.

Reference bug report:
harvester/tests#1311

Negative: Delete cluster network when already set on storage network

Navigate to Networks -> Cluster Networks/Configs, create Cluster Network named vlan2
Create Network Config vlan2-config for all nodes
Navigate to Advanced -> Settings, edit storage-network
Select Enable then select vlan2 as cluster network, fill in VLAN ID and IP Range
Navigate to Networks -> Cluster Networks/Configs, delete Cluster Network vlan2
Warning or error message should displayed

Negative: Delete vlan config when already set on storage network

Navigate to Networks -> Cluster Networks/Configs, create Cluster Network named vlan2
Create Network Config vlan2-config for all nodes
Navigate to Advanced -> Settings, edit storage-network
Select Enable then select vlan2 as cluster network, fill in VLAN ID and IP Range
Navigate to Networks -> Cluster Networks/Configs, delete network config vlan2-config
Warning or error message should displayed

[mingshuoqiu]

LGTM. Thanks

[w13915984028]

One question, thanks.

[w13915984028]

This may be redundant.

The following vlanconfig checks if any vc on this cluster is still existing, then block it. The storagenetwork also relys on one vlanconfig. Checking vlanconfig seems to be enough here.

On the other hand, below function on Harvester needs to check VlanConfig is existing when utilize this vlanconfig to carry the storagenetwork.

func (v *settingValidator) validateStorageNetworkHelper(value string) error {

[rrajendran17]

@w13915984028 yes makes sense, if storage network is validated for vlan config to be present then validating at cluster network will be redundant.I will remove that check.Thanks.

Regarding storage network validating if vlan config is present, I have another pull request (testing still in progress)
where I am checking if cluster network is ready (cluster network becomes ready only if at least one vlan config attached) before configuring storage networks.
harvester/harvester#6538

[starbops]

LGTM, thank you!

[w13915984028]

LGTM, thanks.

[WebberHuang1118]

LGTM, thanks for the PR.

[bk201]

@Mergifyio backport v0.5.x

[mergify]

backport v0.5.x

✅ Backports have been created

• #122 2995 check if storage network attached before cluster network and vlan config config deletion (backport #115) has been created for branch v0.5.x