Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3826 - backport Add validation for cluster network name length #113

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

rrajendran17
Copy link
Contributor

Problem:
cluster network name length is not validated for maximum length when created using API

Solution:
Add validation for cluster network max length in webhook validator of cluster network

Related Issue:

Test plan:
tested manually on harvester node

Copy link

mergify bot commented Aug 15, 2024

⚠️ The sha of the head commit of this PR conflicts with #112. Mergify cannot evaluate rules on this PR. ⚠️

Copy link
Contributor

@mingshuoqiu mingshuoqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants