webhook/mutator: filter out the witness node #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- we do not allow any workload on the witness node, so we should
filter out the witness node when creating the vlan config
Signed-off-by: Vicente Cheng <[email protected]>
|
cc @a110605, backend PR is here. |
3 tasks
|
Hi @Vicente-Cheng , I test with the latest harvester-network-controller. The config filter out witness when first created, but wait for 3 ~ 5 mins the witness node is auto added in matched-nodes annotation. Do we have any mechanism to auto update annotation from backend ? Reproduce Steps:
|
|
@Mergifyio backport v0.4.x |
✅ Backports have been created
|
This was referenced Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The matched-node returns the whole nodes even if we have one witness node.
The witness node did not run any workload, so we should filter out this.
Solution:
we do not allow any workload on the witness node, so we should filter out the witness node when creating the vlan config.
Related Issue:
harvester/harvester#5325 (comment)
Test plan:
Make sure the annotation of vlanconfig response should looks like below (harvester-node-1 is the witness node)