Sure DHCP will work on VLAN interface if VLAN is configured (backport #879) #881
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
DHCP looks to have flaws with VLAN interfaces.
Solution:
Sure the DHCP is working on VLAN interface if VLAN is configured.
This PR has 3 commits:
PR #878 is merged to this one.
Co-authored-by: Kiefer Chang [email protected]
Related Issue:
harvester/harvester#6959
harvester/harvester#3428
Test plan:
Per issue description
Local test:
Installer with this fix, the DHCP discovery frame is encaped with VLAN 100 ( and we did not set a DHCP server on VLAN 100)
Original installer without this fix, the DHCP discovery frame is NOT encaped with VLAN 100
This is an automatic backport of pull request #879 done by Mergify.