fix(dashboard_panels): change to check ready condition in managedchart #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: PoAn Yang <[email protected]>
FrankYang0529
changed the title
bk201
approved these changes
Oct 7, 2024
Yu-Jack
approved these changes
Oct 7, 2024
|
@mergify backport v1.4 |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 7, 2024
…#858) Signed-off-by: PoAn Yang <[email protected]> (cherry picked from commit f778336)
Yu-Jack
pushed a commit
that referenced
this pull request
Oct 7, 2024
…#858) (#859) Signed-off-by: PoAn Yang <[email protected]> (cherry picked from commit f778336) Co-authored-by: PoAn Yang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
In Fleet v0.10.2, it changes to set Ready condition. However, we checked Processed condition.
https://github.com/rancher/fleet/blob/decbf9ae72eff096b2bee5efe05a92fdcbd5627d/internal/cmd/controller/reconciler/bundle_controller.go#L250
Solution:
Change command to check Ready condition.
Related Issue:
harvester/harvester#6690
Test plan: