Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

installer/config: add the role setup #634

Merged

Conversation

Vicente-Cheng
Copy link
Contributor

@Vicente-Cheng Vicente-Cheng commented Jan 18, 2024

Problem:
We tried to support various roles, so the installer need the related changes.

Solution:
Add an interactive part for role selection. Also, we need to add the related label for it.

Related Issue:
harvester/harvester#4786

Test plan:
We can check this feature with two parts as below.

  1. 3 node cluster with one worker node. (Should only have one management(master) in the cluster)
  • create a cluster with three nodes
  • choose worker role on the second or third node
  • make sure the final cluster only has one management(master)
  1. 5 node cluster (to test promote will promote the management role first)
  • create a cluster with five nodes
  • choose management role on the fifth node
  • remove the second or third management (master) node
  • it should promote the fifth node instead fourth node

Copy link
Contributor

@ibrokethecloud ibrokethecloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks.

pkg/config/constants.go Outdated Show resolved Hide resolved
@Vicente-Cheng Vicente-Cheng force-pushed the add-various-role-for-promote branch from c79b9f7 to 0b40d92 Compare January 19, 2024 08:47
@Vicente-Cheng Vicente-Cheng requested a review from bk201 January 19, 2024 08:48
pkg/console/util.go Outdated Show resolved Hide resolved
    Now we support three roles `management`, `worker` and `witness`.
    We need to add the related label to make promote controller
    identify.

Signed-off-by: Vicente Cheng <[email protected]>
@Vicente-Cheng Vicente-Cheng force-pushed the add-various-role-for-promote branch from 0b40d92 to f3fb77e Compare January 23, 2024 07:59
@Vicente-Cheng Vicente-Cheng requested a review from bk201 January 23, 2024 08:01
@Vicente-Cheng Vicente-Cheng merged commit 3857191 into harvester:master Jan 23, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants