installer: rename the role name witness instead etcd #630
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
wip-witness-enhancement
branch
from
e882134 to
c1aecd4
Compare
Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
wip-witness-enhancement
branch
from
c1aecd4 to
2aa3bb5
Compare
2 tasks
|
Tested with basic operations and guest cluster. |
bk201
approved these changes
Jan 12, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
We can use
witnessinsteadetcd. Thewitnessseems more suitable for the configuration.Solution:
Change the console and label content.
Related Issue:
harvester/harvester#4840
Test plan:
Make sure the interactive console show the
Witness Role.And node label should be
node-role.harvesterhci.io/witness: true