Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency resolved and slight performance enhancements #12

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

saadz-khan
Copy link

The issues with its current version:

  • Broken code due to inappropriate requirements.txt
  • Version conflicts between different packages
  • Some unclear steps in the README on data-used and how to retrieve it.
  • GPU usage only (Not everyone owns one)

This PR covers:

  • Slight improvements for performance enhancements.
  • Pinning requirements explicitly requirements.txt with all the proper versions so that code does not break if packages are updated in the future.
  • Update README.md for proper and easy use of the repo.
  • CPU made the default device with clear steps to change to GPU in the config files.
  • data_convert.py example added with proper description and comments for .bin to .txt.src and .txt.tgt file conversion.
  • Descriptive colab-notebook added for getting the data raw cnn-dm stories to .txt.src and .txt.tgt

saadz-khan added 11 commits August 28, 2021 18:26
- This caused huge errors in form of tracebacks.
- Now all depencies are resolved.
- Removed duplicate dependencies between requirements.txt file
- Preprocessing works fine so the project is good to go.
- All dependencies along with the python version mentioned.
- Dataset used and preprocessing steps mentioned.
- Config file alteration mentioned.
- Changed GPU ranks so that CPU is used by default.
- Uncomment the gpu-ranks and according to the number of GPU's being used. Set world_size (1 for 1 GPU or CPU).
- Defaulting to CPU rather then to GPU.
- Comment out the gpu_ranks variable in config and set world_size. (world_size 1 for 1 GPU or CPU)
- Here adding +2 to any n_feats will crash our results.
- .bin file creation from raw stories
- .bin to .txt.src and .txt.tgt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant