New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change elif condition in namer.py #8

Merged

harshil21 merged 1 commit into harshil21:master from jithin-renji:master

Nov 19, 2020

Contributor

jithin-renji commented Nov 19, 2020

I have just changed the condition from elif not bond_type == "ane" to elif bond_type != "ane". It's more idiomatic IMO.


          Change elif condition in namer.py

da99666

Owner

harshil21 commented Nov 19, 2020

I have just changed the condition from elif not bond_type == "ane" to elif bond_type != "ane". It's more idiomatic IMO.

Agreed. Most of that code is being rewritten in #6 anyway, but till then this is good. Merging.

harshil21 merged commit c4ab6df into harshil21:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet